You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "slovdahl (via GitHub)" <gi...@apache.org> on 2025/04/30 06:43:24 UTC
[PR] Include video/mp2t mime type by default [tomcat]
slovdahl opened a new pull request, #848:
URL: https://github.com/apache/tomcat/pull/848
Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=69664.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Include video/mp2t mime type by default [tomcat]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf closed pull request #848: Include video/mp2t mime type by default
URL: https://github.com/apache/tomcat/pull/848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Include video/mp2t mime type by default [tomcat]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #848:
URL: https://github.com/apache/tomcat/pull/848#issuecomment-2841169333
RFC 3555 lists way more as in https://www.iana.org/assignments/media-types/media-types.xhtml#video. Does it make sense to add more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Include video/mp2t mime type by default [tomcat]
Posted by "slovdahl (via GitHub)" <gi...@apache.org>.
slovdahl commented on PR #848:
URL: https://github.com/apache/tomcat/pull/848#issuecomment-2841726094
Awesome, thanks a lot! :bow: Looks good to me, nothing to add from my POV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Include video/mp2t mime type by default [tomcat]
Posted by "slovdahl (via GitHub)" <gi...@apache.org>.
slovdahl commented on PR #848:
URL: https://github.com/apache/tomcat/pull/848#issuecomment-2841452176
Ah, ok. Should I run that script and update this PR with the output of it? I assume "that script" refers to `res/scripts/check-mime.pl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Include video/mp2t mime type by default [tomcat]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #848:
URL: https://github.com/apache/tomcat/pull/848#issuecomment-2841566251
Thanks for the offer but given we'd have to do exactly the same to check the PR there isn't much point you doing it too. Let me run the script and then if you spot any issues with the result such as missing values then we can discuss them - probably on the dev list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Include video/mp2t mime type by default [tomcat]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #848:
URL: https://github.com/apache/tomcat/pull/848#discussion_r2068131344
##########
conf/web.xml:
##########
@@ -3948,6 +3948,10 @@
<extension>trm</extension>
<mime-type>application/x-msterminal</mime-type>
</mime-mapping>
+ <mime-mapping>
+ <extension>ts</extension>
+ <mime-type>video/mp2t</mime-type>
Review Comment:
The canonical name seems to be `[video/MP2T](https://www.iana.org/assignments/media-types/video/MP2T)` (I know that it is case-insensitive)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Include video/mp2t mime type by default [tomcat]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #848:
URL: https://github.com/apache/tomcat/pull/848#issuecomment-2841376298
Tomcat aims to keep in sync with httpd. It looks like we need to run that script again.
Whether we change approaches and try an keep in sync with IANA is probably a broader debate for the dev@ list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Include video/mp2t mime type by default [tomcat]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #848:
URL: https://github.com/apache/tomcat/pull/848#issuecomment-2841685722
I've run the script and updated `conf/web.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org