You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rampart-dev@ws.apache.org by ka...@apache.org on 2007/08/13 12:36:48 UTC

svn commit: r565304 - in /webservices/rampart/trunk/c/src/omxmlsec: axiom.c openssl/pem.c openssl/x509.c

Author: kaushalye
Date: Mon Aug 13 03:36:46 2007
New Revision: 565304

URL: http://svn.apache.org/viewvc?view=rev&rev=565304
Log:
Memory leak fixes

Modified:
    webservices/rampart/trunk/c/src/omxmlsec/axiom.c
    webservices/rampart/trunk/c/src/omxmlsec/openssl/pem.c
    webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c

Modified: webservices/rampart/trunk/c/src/omxmlsec/axiom.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/axiom.c?view=diff&rev=565304&r1=565303&r2=565304
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/axiom.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/axiom.c Mon Aug 13 03:36:46 2007
@@ -340,8 +340,12 @@
                   "Building node failed");
         return NULL;
     }
-    axiom_xml_reader_free(reader, env);
-    reader = NULL;
+    axiom_stax_builder_free_self(builder, env);
+    builder = NULL;
+
+    /*The stax builder will free the reader.*/
+    /*axiom_xml_reader_free(reader, env);
+    reader = NULL;*/
 
     return node;
 }

Modified: webservices/rampart/trunk/c/src/omxmlsec/openssl/pem.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/openssl/pem.c?view=diff&rev=565304&r1=565303&r2=565304
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/openssl/pem.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/openssl/pem.c Mon Aug 13 03:36:46 2007
@@ -108,6 +108,7 @@
         }
     }
 
+    /*Reset before FREE*/
     ret = BIO_reset(bio);
     ret = BIO_free(bio);
     bio = NULL;

Modified: webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c?view=diff&rev=565304&r1=565303&r2=565304
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c Mon Aug 13 03:36:46 2007
@@ -92,9 +92,11 @@
                            axis2_char_t *filename,
                            X509 **cert)
 {
-    BIO *in;
-
-    if ((in=BIO_new_file(filename,"r")) == NULL)
+    BIO *in = NULL;
+    
+    in = BIO_new_file(filename,"r");
+    
+    if (!in)
     {
         /*oxs_error(env, ERROR_LOCATION, OXS_ERROR_DEFAULT,
                 "Error reading the file %s", filename);*/