You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2022/08/26 06:11:50 UTC
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18910
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
This patch renames the Exec libraries to distinguish them from
external libraries like avro, kudu_client and orc
Due to IMPALA-11257, the cmake_minimum_required calls are
also removed from the new libraries
Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
---
M be/CMakeLists.txt
M be/src/exec/avro/CMakeLists.txt
M be/src/exec/hbase/CMakeLists.txt
M be/src/exec/kudu/CMakeLists.txt
M be/src/exec/orc/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/rcfile/CMakeLists.txt
M be/src/exec/sequence/CMakeLists.txt
M be/src/exec/text/CMakeLists.txt
9 files changed, 38 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/18910/2
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 2: Code-Review+1
Looks good to me, I'll let others take a look at it too.
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Aug 2022 09:44:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 21:34:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8522/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 21:34:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11229/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Aug 2022 06:32:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 2:
Thanks for putting this together! One other small thing:
Since some IR files moved to a different library, I think we also should update be/src/codegen/CMakeLists.txt.
This location refers to Exec, but I think it now needs to refer to ExecAvro and ExecKudu as well:
https://github.com/apache/impala/blob/master/be/src/codegen/CMakeLists.txt#L88
https://github.com/apache/impala/blob/master/be/src/codegen/CMakeLists.txt#L98
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Aug 2022 16:23:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18910/3/be/src/codegen/CMakeLists.txt
File be/src/codegen/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/18910/3/be/src/codegen/CMakeLists.txt@98
PS3, Line 98: DEPENDS ExecAvro ExecKudu Exprs Runtime Udf Util ${IR_INPUT_FILES}
Keep the ordinary Exec as well. It has some "-ir.cc" files as part of it.
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 00:30:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Sep 2022 02:22:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18910
to look at the new patch set (#3).
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
This patch renames the Exec libraries to distinguish them from
external libraries like avro, kudu_client and orc
Due to IMPALA-11257, the cmake_minimum_required calls are
also removed from the new libraries
Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
---
M be/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/exec/avro/CMakeLists.txt
M be/src/exec/hbase/CMakeLists.txt
M be/src/exec/kudu/CMakeLists.txt
M be/src/exec/orc/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/rcfile/CMakeLists.txt
M be/src/exec/sequence/CMakeLists.txt
M be/src/exec/text/CMakeLists.txt
10 files changed, 40 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/18910/3
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 3:
> Thanks for putting this together! One other small thing:
> Since some IR files moved to a different library, I think we also
> should update be/src/codegen/CMakeLists.txt.
>
> This location refers to Exec, but I think it now needs to refer to
> ExecAvro and ExecKudu as well:
> https://github.com/apache/impala/blob/master/be/src/codegen/CMakeLists.txt#L88
> https://github.com/apache/impala/blob/master/be/src/codegen/CMakeLists.txt#L98
Done
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 09:50:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 2: Code-Review+1
lgtm, but I would wait for the opinion of Joe
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Aug 2022 11:03:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18910
to look at the new patch set (#4).
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
This patch renames the Exec libraries to distinguish them from
external libraries like avro, kudu_client and orc
Due to IMPALA-11257, the cmake_minimum_required calls are
also removed from the new libraries
Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
---
M be/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/exec/avro/CMakeLists.txt
M be/src/exec/hbase/CMakeLists.txt
M be/src/exec/kudu/CMakeLists.txt
M be/src/exec/orc/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/rcfile/CMakeLists.txt
M be/src/exec/sequence/CMakeLists.txt
M be/src/exec/text/CMakeLists.txt
10 files changed, 40 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/18910/4
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18910/3/be/src/codegen/CMakeLists.txt
File be/src/codegen/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/18910/3/be/src/codegen/CMakeLists.txt@98
PS3, Line 98: DEPENDS ExecAvro ExecKudu Exprs Runtime Udf Util ${IR_INPUT_FILES}
> Keep the ordinary Exec as well. It has some "-ir.cc" files as part of it.
Done
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 11:43:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11276/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 12:03:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11237/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 10:10:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
Patch Set 4: Code-Review+2
Looks good! Thanks for tracking this down!
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 16:52:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
......................................................................
IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries
This patch renames the Exec libraries to distinguish them from
external libraries like avro, kudu_client and orc
Due to IMPALA-11257, the cmake_minimum_required calls are
also removed from the new libraries
Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Reviewed-on: http://gerrit.cloudera.org:8080/18910
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/exec/avro/CMakeLists.txt
M be/src/exec/hbase/CMakeLists.txt
M be/src/exec/kudu/CMakeLists.txt
M be/src/exec/orc/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/rcfile/CMakeLists.txt
M be/src/exec/sequence/CMakeLists.txt
M be/src/exec/text/CMakeLists.txt
10 files changed, 40 insertions(+), 54 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0
Gerrit-Change-Number: 18910
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>