[GitHub] [incubator-paimon] LsomeYeah commented on a diff in pull request #1416: [core] implement adjustProjection in PartialUpdateMergeFunction

["LsomeYeah (via GitHub)" <gi...@apache.org>]

LsomeYeah commented on code in PR #1416:
URL: https://github.com/apache/incubator-paimon/pull/1416#discussion_r1236380077


##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java:
##########
@@ -203,7 +231,35 @@ public AdjustedProjection adjustProjection(@Nullable int[][] projection) {
             if (fieldSequences.isEmpty()) {
                 return new AdjustedProjection(projection, null);
             }
-            // TODO implement this, just keep required fields and adjust fieldSequences too.
+
+            if (projection != null) {
+                int[] projIndexs = Projection.of(projection).toTopLevelIndexes();

Review Comment:
   There may be some sequence fields in `topProjects`, we don't need to add these fields to `extraFields`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org