You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/09 08:21:05 UTC
[GitHub] [shardingsphere] harvies opened a new pull request #6739: test cases for issues#6753
harvies opened a new pull request #6739:
URL: https://github.com/apache/shardingsphere/pull/6739
Fixes #6733.
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] harvies commented on a change in pull request #6739: test cases for issues#6753
Posted by GitBox <gi...@apache.org>.
harvies commented on a change in pull request #6739:
URL: https://github.com/apache/shardingsphere/pull/6739#discussion_r467591253
##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/spi/singleton/SingletonServiceLoaderTest.java
##########
@@ -26,9 +27,10 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
public final class SingletonServiceLoaderTest {
-
+
Review comment:
The idea configuration imported through the official website seems to be wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #6739: test cases for issues#6753
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6739:
URL: https://github.com/apache/shardingsphere/pull/6739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #6739: test cases for issues#6753
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #6739:
URL: https://github.com/apache/shardingsphere/pull/6739#discussion_r467555994
##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/spi/singleton/SingletonServiceLoaderTest.java
##########
@@ -26,9 +27,10 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
public final class SingletonServiceLoaderTest {
-
+
Review comment:
Please do not change the original intent, please update your IDEA code format settings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] harvies commented on pull request #6739: test cases for issues#6753
Posted by GitBox <gi...@apache.org>.
harvies commented on pull request #6739:
URL: https://github.com/apache/shardingsphere/pull/6739#issuecomment-671061936
https://github.com/apache/shardingsphere/issues/6741
Help me look at this issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org