[GitHub] [spark] ulysses-you commented on a diff in pull request #36936: [SPARK-39503][SQL] Add session catalog name for v1 database table and function

[GitBox <gi...@apache.org>]

ulysses-you commented on code in PR #36936:
URL: https://github.com/apache/spark/pull/36936#discussion_r909614603


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala:
##########
@@ -895,7 +905,7 @@ case class ShowTablesCommand(
       val normalizedSpec = PartitioningUtils.normalizePartitionSpec(
         partitionSpec.get,
         table.partitionSchema,
-        tableIdent.quotedString,
+        tableIdent.quotedString(SESSION_CATALOG_NAME),
         sparkSession.sessionState.conf.resolver)
       val partition = catalog.getPartition(tableIdent, normalizedSpec)
       val database = tableIdent.database.getOrElse("")

Review Comment:
   thank you @tomvanbussel for pointing out this, actually it is out of scope of this pr. We can support improve the output attribute of some related commands in future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org