You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/09/30 00:12:03 UTC
Review Request 26154: Stop sending and receiving DeletedTasks
framework message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Brian Wickman.
Bugs: AURORA-764
https://issues.apache.org/jira/browse/AURORA-764
Repository: aurora
Description
-------
Stop sending and receiving DeletedTasks framework message.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee
src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405
src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4
src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2
src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8
Diff: https://reviews.apache.org/r/26154/diff/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Bill Farner
Re: Review Request 26154: Stop sending and receiving DeletedTasks
framework message.
Posted by Bill Farner <wf...@apache.org>.
> On Sept. 29, 2014, 10:26 p.m., Kevin Sweeney wrote:
> > src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java, line 21
> > <https://reviews.apache.org/r/26154/diff/1/?file=708562#file708562line21>
> >
> > Prefer http://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html
> >
> > From https://code.google.com/p/guava-libraries/wiki/StringsExplained
> >
> > (Note: If you're using JDK7, you should use the constants in StandardCharsets instead!)
Thanks! Done throughout the project.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/#review54898
-----------------------------------------------------------
On Sept. 29, 2014, 10:12 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26154/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 10:12 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: AURORA-764
> https://issues.apache.org/jira/browse/AURORA-764
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop sending and receiving DeletedTasks framework message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee
> src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4
> src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2
> src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8
>
> Diff: https://reviews.apache.org/r/26154/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26154: Stop sending and receiving DeletedTasks
framework message.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/#review54898
-----------------------------------------------------------
Ship it!
src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java
<https://reviews.apache.org/r/26154/#comment95229>
Prefer http://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html
From https://code.google.com/p/guava-libraries/wiki/StringsExplained
(Note: If you're using JDK7, you should use the constants in StandardCharsets instead!)
- Kevin Sweeney
On Sept. 29, 2014, 3:12 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26154/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 3:12 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: AURORA-764
> https://issues.apache.org/jira/browse/AURORA-764
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop sending and receiving DeletedTasks framework message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee
> src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4
> src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2
> src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8
>
> Diff: https://reviews.apache.org/r/26154/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26154: Stop sending and receiving DeletedTasks
framework message.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/#review55013
-----------------------------------------------------------
Ping - Brian?
- Bill Farner
On Sept. 30, 2014, 3:36 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26154/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 3:36 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: AURORA-764
> https://issues.apache.org/jira/browse/AURORA-764
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop sending and receiving DeletedTasks framework message.
>
>
> Diffs
> -----
>
> build.gradle 325a50e628ec0e2e21e812ef1daba98fc99a43d4
> src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java 2b96427b795227bf92c9866a7df808786efbd93c
> src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler.java 826c0adb17ec8d5fec481bae28f5bf7f17d5c5c2
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 71bc4c903aa389cf8a4c90d2ad07af062ed81829
> src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4
> src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2
> src/test/java/org/apache/aurora/scheduler/cron/ExpectedPrediction.java ccfbecb6fed2ae3ce01ba712dee932454bb6127b
> src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java ec467aa9a916ff8bcfc5d7fdc1ee6d85a0650157
> src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 35ccd14ea65fb3421b3fcdb1840175d4f724e6b6
> src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8
>
> Diff: https://reviews.apache.org/r/26154/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26154: Stop sending and receiving DeletedTasks
framework message.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/#review54986
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 30, 2014, 3:36 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26154/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 3:36 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: AURORA-764
> https://issues.apache.org/jira/browse/AURORA-764
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop sending and receiving DeletedTasks framework message.
>
>
> Diffs
> -----
>
> build.gradle 325a50e628ec0e2e21e812ef1daba98fc99a43d4
> src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java 2b96427b795227bf92c9866a7df808786efbd93c
> src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler.java 826c0adb17ec8d5fec481bae28f5bf7f17d5c5c2
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 71bc4c903aa389cf8a4c90d2ad07af062ed81829
> src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4
> src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2
> src/test/java/org/apache/aurora/scheduler/cron/ExpectedPrediction.java ccfbecb6fed2ae3ce01ba712dee932454bb6127b
> src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java ec467aa9a916ff8bcfc5d7fdc1ee6d85a0650157
> src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 35ccd14ea65fb3421b3fcdb1840175d4f724e6b6
> src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8
>
> Diff: https://reviews.apache.org/r/26154/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26154: Stop sending and receiving DeletedTasks
framework message.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/#review55015
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Sept. 30, 2014, 3:36 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26154/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 3:36 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: AURORA-764
> https://issues.apache.org/jira/browse/AURORA-764
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop sending and receiving DeletedTasks framework message.
>
>
> Diffs
> -----
>
> build.gradle 325a50e628ec0e2e21e812ef1daba98fc99a43d4
> src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java 2b96427b795227bf92c9866a7df808786efbd93c
> src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler.java 826c0adb17ec8d5fec481bae28f5bf7f17d5c5c2
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 71bc4c903aa389cf8a4c90d2ad07af062ed81829
> src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4
> src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2
> src/test/java/org/apache/aurora/scheduler/cron/ExpectedPrediction.java ccfbecb6fed2ae3ce01ba712dee932454bb6127b
> src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java ec467aa9a916ff8bcfc5d7fdc1ee6d85a0650157
> src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 35ccd14ea65fb3421b3fcdb1840175d4f724e6b6
> src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8
>
> Diff: https://reviews.apache.org/r/26154/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26154: Stop sending and receiving DeletedTasks
framework message.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/
-----------------------------------------------------------
(Updated Sept. 30, 2014, 3:36 a.m.)
Review request for Aurora, Maxim Khutornenko and Brian Wickman.
Bugs: AURORA-764
https://issues.apache.org/jira/browse/AURORA-764
Repository: aurora
Description
-------
Stop sending and receiving DeletedTasks framework message.
Diffs (updated)
-----
build.gradle 325a50e628ec0e2e21e812ef1daba98fc99a43d4
src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee
src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java 2b96427b795227bf92c9866a7df808786efbd93c
src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler.java 826c0adb17ec8d5fec481bae28f5bf7f17d5c5c2
src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 71bc4c903aa389cf8a4c90d2ad07af062ed81829
src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405
src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4
src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2
src/test/java/org/apache/aurora/scheduler/cron/ExpectedPrediction.java ccfbecb6fed2ae3ce01ba712dee932454bb6127b
src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java ec467aa9a916ff8bcfc5d7fdc1ee6d85a0650157
src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 35ccd14ea65fb3421b3fcdb1840175d4f724e6b6
src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8
Diff: https://reviews.apache.org/r/26154/diff/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Bill Farner
Re: Review Request 26154: Stop sending and receiving DeletedTasks
framework message.
Posted by Bill Farner <wf...@apache.org>.
> On Sept. 29, 2014, 10:51 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/executor/gc_executor.py, line 439
> > <https://reviews.apache.org/r/26154/diff/1/?file=708560#file708560line439>
> >
> > Should the reconcile_states() be adjusted as well to not return remote_gc set? Seems like a logical cleanup to do here.
I looked into this early on, but backed away because `reconcile_states` is directly called in unit tests so i stopped short. My approach on this is also influenced by the impending sunsetting of the GC executor, so i would like to avoid unnecessary churn.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/#review54903
-----------------------------------------------------------
On Sept. 29, 2014, 10:12 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26154/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 10:12 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: AURORA-764
> https://issues.apache.org/jira/browse/AURORA-764
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop sending and receiving DeletedTasks framework message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee
> src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4
> src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2
> src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8
>
> Diff: https://reviews.apache.org/r/26154/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26154: Stop sending and receiving DeletedTasks
framework message.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26154/#review54903
-----------------------------------------------------------
src/main/python/apache/aurora/executor/gc_executor.py
<https://reviews.apache.org/r/26154/#comment95235>
Should the reconcile_states() be adjusted as well to not return remote_gc set? Seems like a logical cleanup to do here.
- Maxim Khutornenko
On Sept. 29, 2014, 10:12 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26154/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 10:12 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: AURORA-764
> https://issues.apache.org/jira/browse/AURORA-764
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop sending and receiving DeletedTasks framework message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee
> src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4
> src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2
> src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8
>
> Diff: https://reviews.apache.org/r/26154/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>