You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/11/02 07:11:26 UTC

[GitHub] [lucenenet] nikcio commented on issue #648: Which kinds of PR's would you like to get?

nikcio commented on issue #648:
URL: https://github.com/apache/lucenenet/issues/648#issuecomment-1299678389

   @NightOwl888 I've just looked a bit on it and I don't think the rule is wrong. If you read the title it says it's because the class is marked abstract and therefore can't be instantiated: https://sonarcloud.io/organizations/nikcio/rules?open=csharpsquid%3AS3442&rule_key=csharpsquid%3AS3442
   
   Therefore, in the example it would make most sense to change the modifier to `protected` and not private. If you would maintain the same level of access and is not taking the Java source into account (as you stated the modifier is wrong and should be private)
   
   Do note that the rule specifics that the modifier shouldn't be public/internal not that it should always be private.😉


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org