You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/09/20 01:36:33 UTC
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23447
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
[thirdparty] upgrade cpplint up to 1.6.1 release
The prior version of the cpplint tool from the google-styleguide project
[1] was from 2016 and it wasn't aware of the C++17 constructs such as
'if constexpr (...) {...}', so it would error out on such a code with
messages like below:
If/else bodies with multiple statements require braces [readability/braces]
At the time of writing, the latest released version of the cpplint tool
is 2.0.2 [2]. However, version 2.0.0 dropped Python2 and Python3.7
support, and it seems the 2.0.x release line is not quite stable yet.
The safest bet at this time is 1.6.1 which includes the fix for the
issue [3] and is the latest release in the 1.x line. It was released
about 3 years ago in August 2022.
Since the cpplint tool has been moved into a separate repo [4] and
it isn't a part of the google-styleguide project repo [1] anymore,
I renamed corresponding entities for this Kudu's 3rd-party component
and updated the scripts accordingly:
GSG --> CPPLINT
[1] https://github.com/google/styleguide
[2] https://github.com/cpplint/cpplint/releases/tag/2.0.2
[3] https://github.com/cpplint/cpplint/commit/6e3e178b0
[4] https://github.com/cpplint/cpplint
Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
---
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/patches/google-styleguide-cpplint.patch
M thirdparty/vars.sh
5 files changed, 24 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/23447/1
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1826/
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sat, 20 Sep 2025 01:52:46 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Overall looks good, I just have one question.
http://gerrit.cloudera.org:8080/#/c/23447/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23447/3//COMMIT_MSG@18
PS3, Line 18: 2.0.x release line is not quite stable yet
Do you have specific evidence of instability, or is this more of a conservative approach?
http://gerrit.cloudera.org:8080/#/c/23447/3/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/23447/3/thirdparty/vars.sh@124
PS3, Line 124: git co 1.6.1
nit: For better clarity and copy-pasteable documentation, consider using the full command git checkout 1.6.1 instead of the alias git co 1.6.1, since not all users may have this alias configured.
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 09:30:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Gabriella Lotz, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23447
to look at the new patch set (#2).
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
[thirdparty] upgrade cpplint up to 1.6.1 release
The prior version of the cpplint tool from the google-styleguide project
[1] was from 2016 and it wasn't aware of the C++17 constructs such as
'if constexpr (...) {...}', so it would error out on such a code with
messages like below:
If/else bodies with multiple statements require braces [readability/braces]
At the time of writing, the latest released version of the cpplint tool
is 2.0.2 [2]. However, version 2.0.0 dropped Python2 and Python3.7
support, and it seems the 2.0.x release line is not quite stable yet.
The safest bet at this time is 1.6.1 which includes the fix for the
issue [3] and is the latest release in the 1.x line. It was released
about 3 years ago in August 2022.
Since the cpplint tool has been moved into a separate repo [4] and
it isn't a part of the google-styleguide project repo [1] anymore,
I renamed corresponding entities for this Kudu's 3rd-party component
and updated the scripts accordingly:
GSG --> CPPLINT
[1] https://github.com/google/styleguide
[2] https://github.com/cpplint/cpplint/releases/tag/2.0.2
[3] https://github.com/cpplint/cpplint/commit/6e3e178b0
[4] https://github.com/cpplint/cpplint
Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
---
M thirdparty/LICENSE.txt
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
R thirdparty/patches/cpplint-libstdcpp-regex.patch
M thirdparty/vars.sh
6 files changed, 28 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/23447/2
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1826/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sat, 20 Sep 2025 02:13:32 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 08:16:30 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1831/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 05:37:55 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1837/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 00:47:11 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1825/
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Sep 2025 01:36:41 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1825/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sat, 20 Sep 2025 01:49:22 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sat, 20 Sep 2025 05:07:08 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 5: Verified+1
ASAN, TSAN: unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 06:17:47 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 5: Code-Review+2
Thanks for this update!
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 08:14:45 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1837/
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 00:36:40 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23447/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23447/3//COMMIT_MSG@18
PS3, Line 18: 2.0.x release line is not quite stable yet
> Do you have specific evidence of instability, or is this more of a conserva
Sure: the cadence of patch releases was a part of such evidence for me. Just look at the cadence of 2.0.x releases. Per description, 2.0.2 is a hotfix release, and 2.0.1 was a bugfix release as well.
Also, take a look at the big date gap between 1.6.1 and 2.0.0 releases. All this is telling me that switching to 2.0.x branch right now isn't the best bet, even if assuming we are about to drop Python2 and Python3.7 support in Kudu in the nearest future.
As for particular behavior and the functionality of the cpplint tool in the 2.0.x branch, I haven't even tried it because the dropped support of Python2 and Python 3.7 was already a no-go criterion for me.
http://gerrit.cloudera.org:8080/#/c/23447/3/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/23447/3/thirdparty/vars.sh@124
PS3, Line 124: git co 1.6.1
> nit: For better clarity and copy-pasteable documentation, consider using th
Done
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 00:42:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 5:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1841/
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 02:35:10 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1831/
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 05:27:35 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Gabriella Lotz, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23447
to look at the new patch set (#4).
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
[thirdparty] upgrade cpplint up to 1.6.1 release
The prior version of the cpplint tool from the google-styleguide project
[1] was from 2016 and it wasn't aware of the C++17 constructs such as
'if constexpr (...) {...}', so it would error out on such a code with
messages like below:
If/else bodies with multiple statements require braces [readability/braces]
At the time of writing, the latest released version of the cpplint tool
is 2.0.2 [2]. However, version 2.0.0 dropped Python2 and Python3.7
support, and it seems the 2.0.x release line is not quite stable yet.
The safest bet at this time is 1.6.1 which includes the fix for the
issue [3] and is the latest release in the 1.x line. It was released
about 3 years ago in August 2022.
Since the cpplint tool has been moved into a separate repo [4] and
it isn't a part of the google-styleguide project repo [1] anymore,
I renamed corresponding entities for this Kudu's 3rd-party component
and updated the scripts accordingly:
GSG --> CPPLINT
I also updated the list of cpplint filters to make the code pass the
checks of the upgraded cpplint tool. That should be addressed in
a separate follow-up changelist(s), and it might entail reconciliation
with the IWYU tool suggestions on the same set of header files, patching
the cpplint tool itself, addressing many of the runtime/string issues,
and adding NOLINT() where addressing the reported issues doesn't seem
viable:
* runtime/string is disabled since it doesn't recognize static
function declarations like in src/kudu/client/client.h, so it
will require either fixing it in cpplint itself or adding
NOLINT(runtime/string) as necessary
* build/include_what_you_use is disabled because it suggests including
the <utility> header in many places, but the IWYU tool itself
insists on removing it instead
[1] https://github.com/google/styleguide
[2] https://github.com/cpplint/cpplint/releases/tag/2.0.2
[3] https://github.com/cpplint/cpplint/commit/6e3e178b0
[4] https://github.com/cpplint/cpplint
Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
---
M build-support/lint.sh
M thirdparty/LICENSE.txt
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
R thirdparty/patches/cpplint-libstdcpp-regex.patch
M thirdparty/vars.sh
7 files changed, 29 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/23447/4
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
[thirdparty] upgrade cpplint up to 1.6.1 release
The prior version of the cpplint tool from the google-styleguide project
[1] was from 2016 and it wasn't aware of the C++17 constructs such as
'if constexpr (...) {...}', so it would error out on such a code with
messages like below:
If/else bodies with multiple statements require braces [readability/braces]
At the time of writing, the latest released version of the cpplint tool
is 2.0.2 [2]. However, version 2.0.0 dropped Python2 and Python3.7
support, and it seems the 2.0.x release line is not quite stable yet.
The safest bet at this time is 1.6.1 which includes the fix for the
issue [3] and is the latest release in the 1.x line. It was released
about 3 years ago in August 2022.
Since the cpplint tool has been moved into a separate repo [4] and
it isn't a part of the google-styleguide project repo [1] anymore,
I renamed corresponding entities for this Kudu's 3rd-party component
and updated the scripts accordingly:
GSG --> CPPLINT
I also updated the list of cpplint filters to make the code pass the
checks of the upgraded cpplint tool. That should be addressed in
a separate follow-up changelist(s), and it might entail reconciliation
with the IWYU tool suggestions on the same set of header files, patching
the cpplint tool itself, addressing many of the runtime/string issues,
and adding NOLINT() where addressing the reported issues doesn't seem
viable:
* runtime/string is disabled since it doesn't recognize static
function declarations like in src/kudu/client/client.h, so it
will require either fixing it in cpplint itself or adding
NOLINT(runtime/string) as necessary
* build/include_what_you_use is disabled because it suggests including
the <utility> header in many places, but the IWYU tool itself
insists on removing it instead
[1] https://github.com/google/styleguide
[2] https://github.com/cpplint/cpplint/releases/tag/2.0.2
[3] https://github.com/cpplint/cpplint/commit/6e3e178b0
[4] https://github.com/cpplint/cpplint
Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Reviewed-on: http://gerrit.cloudera.org:8080/23447
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
---
M build-support/lint.sh
M thirdparty/LICENSE.txt
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
R thirdparty/patches/cpplint-libstdcpp-regex.patch
M thirdparty/vars.sh
7 files changed, 29 insertions(+), 63 deletions(-)
Approvals:
Alexey Serbin: Verified
Marton Greber: Looks good to me, approved
Gabriella Lotz: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [thirdparty] upgrade cpplint up to 1.6.1 release
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23447 )
Change subject: [thirdparty] upgrade cpplint up to 1.6.1 release
......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1841/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390dad51e8e0a57e5823ad789f7f8b0029e5bdb4
Gerrit-Change-Number: 23447
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 03:59:05 +0000
Gerrit-HasComments: No