You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "platoneko (via GitHub)" <gi...@apache.org> on 2023/02/17 14:02:44 UTC
[GitHub] [doris] platoneko opened a new pull request, #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
platoneko opened a new pull request, #16889:
URL: https://github.com/apache/doris/pull/16889
# Proposed changes
Issue Number: close #xxx
## Problem summary
`tablet` may be a dropped replica in FE, e.g:
BE1 migrates replica of tablet_1 to BE2, but before BE1 drop this replica, another new replica of tablet_1 is migrated to BE1.
We MUST NOT allow to clone success on dropped replica, otherwise replica id may never be consistent between FE and BE, which may affect operations that depend on the replica id (i.e. drop tablet, cooldown).
Also, when FE tries to add replica during handling `tabletReport`, it MUST create new Replica with `replicaId` reported by BE to maintain replica meta consistent between FE and BE.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1438025644
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1437174813
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.56 seconds
stream load tsv: 469 seconds loaded 74807831229 Bytes, about 152 MB/s
stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 27 seconds loaded 861443392 Bytes, about 30 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230220151406_clickbench_pr_100420.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1437328855
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1438635190
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #16889:
URL: https://github.com/apache/doris/pull/16889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1437392701
build feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1438355910
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1437062027
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1434706784
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1438189360
build clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1438635108
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1434699331
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1436634599
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1437330260
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #16889:
URL: https://github.com/apache/doris/pull/16889#issuecomment-1437392582
build p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org