[GitHub] [arrow] jorisvandenbossche commented on pull request #7236: ARROW-8703: [R] schema$metadata should be properly typed

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on pull request #7236:
URL: https://github.com/apache/arrow/pull/7236#issuecomment-631924558


   That looks good to me. 
   In Python, we don't allow editing the metadata in-place (there are methods to add or update it, but those return a new table / new schema), so in that sense we follow more how it is done on the C++ side, but I don't think it is a problem to update the pointer in place.
   
   One question: if you do like `tab$metadata <- list(test = TRUE)`, I understand in the code how this change is propagated to the actual table, but if you do `tab$metadata$foo <- 42` (which updates the named list), how is that propagated to the metadata on the C++ level?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org