You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2017/02/23 07:51:33 UTC
Review Request 56974: Services should be able to specify that
credential store is always enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56974/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, and Sid Wagle.
Bugs: AMBARI-20136
https://issues.apache.org/jira/browse/AMBARI-20136
Repository: ambari
Description
-------
Details in the JIRA
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java a1c53a7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 504da49
ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java 43f6690
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 0f425a4
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 713c189
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 56fcd74
ambari-server/src/main/resources/properties.json 698b6c5
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml f2002e1
ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER/metainfo.xml 97bc19f
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 7afbfb7
ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml cc25d44
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c40ff64
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java 3034459
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 281c77e
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/STORM/metainfo.xml 6075ba3
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/ZOOKEEPER/metainfo.xml ed0a132
Diff: https://reviews.apache.org/r/56974/diff/
Testing
-------
Ran all unit tests locally -
i-server-2.0.0.0-SNAPSHOT-dist.tar.gz
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.673s]
[INFO] utility ........................................... SUCCESS [1.361s]
[INFO] Ambari Metrics Common ............................. SUCCESS [7.726s]
[INFO] Ambari Server ..................................... SUCCESS [26:48.326s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:01.578s
[INFO] Finished at: Wed Feb 22 23:43:51 PST 2017
[INFO] Final Memory: 96M/658M
[INFO] ------------------------------------------------------------------------
[smohanty@HW12158 asf-ambari (trunk)]$
Thanks,
Sumit Mohanty
Re: Review Request 56974: Services should be able to specify that
credential store is always enabled
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Feb. 24, 2017, 7:04 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java, line 481
> > <https://reviews.apache.org/r/56974/diff/1/?file=1645343#file1645343line481>
> >
> > Minor nit: Null check not needed since it is primitive type, default would be false.
credentialStoreInfo.isRequired() returns a Boolean and that can be null. It did throw NPE possibly while doing the conversion. So left the code as is.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56974/#review166745
-----------------------------------------------------------
On Feb. 25, 2017, 1:29 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56974/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2017, 1:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, and Sid Wagle.
>
>
> Bugs: AMBARI-20136
> https://issues.apache.org/jira/browse/AMBARI-20136
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Details in the JIRA
>
> Removed credential store sections from Ranger as Ranger does not use the Ambari feature.
>
> Once this feature is in, LogSearch will be modified to make CS as a required capability.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java ec45a85
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java a6dd31f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java a1c53a7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 504da49
> ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java 43f6690
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 0f425a4
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 713c189
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java a38af29
> ambari-server/src/main/resources/properties.json 698b6c5
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml f2002e1
> ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER/metainfo.xml 97bc19f
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 7afbfb7
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml cc25d44
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 8859d7f
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java 3b963a8
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java 3034459
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 281c77e
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/STORM/metainfo.xml 6075ba3
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/ZOOKEEPER/metainfo.xml ed0a132
>
> Diff: https://reviews.apache.org/r/56974/diff/
>
>
> Testing
> -------
>
> Ran all unit tests locally -
>
> i-server-2.0.0.0-SNAPSHOT-dist.tar.gz
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.673s]
> [INFO] utility ........................................... SUCCESS [1.361s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [7.726s]
> [INFO] Ambari Server ..................................... SUCCESS [26:48.326s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:01.578s
> [INFO] Finished at: Wed Feb 22 23:43:51 PST 2017
> [INFO] Final Memory: 96M/658M
> [INFO] ------------------------------------------------------------------------
> [smohanty@HW12158 asf-ambari (trunk)]$
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 56974: Services should be able to specify that
credential store is always enabled
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56974/#review166745
-----------------------------------------------------------
Fix it, then Ship it!
In general, patch looks good to me.
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java (line 481)
<https://reviews.apache.org/r/56974/#comment238776>
Minor nit: Null check not needed since it is primitive type, default would be false.
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java (line 10364)
<https://reviews.apache.org/r/56974/#comment238775>
Can you rename the test to convey more meaning, optinally add comments for future ref. Thanks.
- Sid Wagle
On Feb. 23, 2017, 7:53 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56974/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 7:53 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, and Sid Wagle.
>
>
> Bugs: AMBARI-20136
> https://issues.apache.org/jira/browse/AMBARI-20136
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Details in the JIRA
>
> Removed credential store sections from Ranger as Ranger does not use the Ambari feature.
>
> Once this feature is in, LogSearch will be modified to make CS as a required capability.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java a1c53a7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 504da49
> ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java 43f6690
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 0f425a4
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 713c189
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 56fcd74
> ambari-server/src/main/resources/properties.json 698b6c5
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml f2002e1
> ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER/metainfo.xml 97bc19f
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 7afbfb7
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml cc25d44
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c40ff64
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java 3034459
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 281c77e
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/STORM/metainfo.xml 6075ba3
> ambari-server/src/test/resources/stacks/HDP/2.2.0/services/ZOOKEEPER/metainfo.xml ed0a132
>
> Diff: https://reviews.apache.org/r/56974/diff/
>
>
> Testing
> -------
>
> Ran all unit tests locally -
>
> i-server-2.0.0.0-SNAPSHOT-dist.tar.gz
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.673s]
> [INFO] utility ........................................... SUCCESS [1.361s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [7.726s]
> [INFO] Ambari Server ..................................... SUCCESS [26:48.326s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:01.578s
> [INFO] Finished at: Wed Feb 22 23:43:51 PST 2017
> [INFO] Final Memory: 96M/658M
> [INFO] ------------------------------------------------------------------------
> [smohanty@HW12158 asf-ambari (trunk)]$
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 56974: Services should be able to specify that
credential store is always enabled
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56974/
-----------------------------------------------------------
(Updated Feb. 25, 2017, 1:29 a.m.)
Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, and Sid Wagle.
Bugs: AMBARI-20136
https://issues.apache.org/jira/browse/AMBARI-20136
Repository: ambari
Description
-------
Details in the JIRA
Removed credential store sections from Ranger as Ranger does not use the Ambari feature.
Once this feature is in, LogSearch will be modified to make CS as a required capability.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java ec45a85
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java a6dd31f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java a1c53a7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 504da49
ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java 43f6690
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 0f425a4
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 713c189
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java a38af29
ambari-server/src/main/resources/properties.json 698b6c5
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml f2002e1
ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER/metainfo.xml 97bc19f
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 7afbfb7
ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml cc25d44
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 8859d7f
ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java 3b963a8
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java 3034459
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 281c77e
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/STORM/metainfo.xml 6075ba3
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/ZOOKEEPER/metainfo.xml ed0a132
Diff: https://reviews.apache.org/r/56974/diff/
Testing
-------
Ran all unit tests locally -
i-server-2.0.0.0-SNAPSHOT-dist.tar.gz
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.673s]
[INFO] utility ........................................... SUCCESS [1.361s]
[INFO] Ambari Metrics Common ............................. SUCCESS [7.726s]
[INFO] Ambari Server ..................................... SUCCESS [26:48.326s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:01.578s
[INFO] Finished at: Wed Feb 22 23:43:51 PST 2017
[INFO] Final Memory: 96M/658M
[INFO] ------------------------------------------------------------------------
[smohanty@HW12158 asf-ambari (trunk)]$
Thanks,
Sumit Mohanty
Re: Review Request 56974: Services should be able to specify that
credential store is always enabled
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56974/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 7:53 a.m.)
Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, and Sid Wagle.
Bugs: AMBARI-20136
https://issues.apache.org/jira/browse/AMBARI-20136
Repository: ambari
Description (updated)
-------
Details in the JIRA
Removed credential store sections from Ranger as Ranger does not use the Ambari feature.
Once this feature is in, LogSearch will be modified to make CS as a required capability.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java a1c53a7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 504da49
ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java 43f6690
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 0f425a4
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 713c189
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 56fcd74
ambari-server/src/main/resources/properties.json 698b6c5
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml f2002e1
ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER/metainfo.xml 97bc19f
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 7afbfb7
ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml cc25d44
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c40ff64
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceInfoTest.java 3034459
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/HDFS/metainfo.xml 281c77e
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/STORM/metainfo.xml 6075ba3
ambari-server/src/test/resources/stacks/HDP/2.2.0/services/ZOOKEEPER/metainfo.xml ed0a132
Diff: https://reviews.apache.org/r/56974/diff/
Testing
-------
Ran all unit tests locally -
i-server-2.0.0.0-SNAPSHOT-dist.tar.gz
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.673s]
[INFO] utility ........................................... SUCCESS [1.361s]
[INFO] Ambari Metrics Common ............................. SUCCESS [7.726s]
[INFO] Ambari Server ..................................... SUCCESS [26:48.326s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:01.578s
[INFO] Finished at: Wed Feb 22 23:43:51 PST 2017
[INFO] Final Memory: 96M/658M
[INFO] ------------------------------------------------------------------------
[smohanty@HW12158 asf-ambari (trunk)]$
Thanks,
Sumit Mohanty