You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "zhaoyudi-creator (via GitHub)" <gi...@apache.org> on 2026/08/28 14:41:09 UTC
[PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
zhaoyudi-creator opened a new pull request, #19785:
URL: https://github.com/apache/hudi/pull/19785
### Change Logs
A MOR file group can have its latest file slice keyed on a base instant
that never committed. For example, under NBCC with the bucket index a
delta commit fails (or is rolled back) while later delta commits on the
same file group succeed; log files are attributed to a slice by completion
time, so the failed instant's log and the later committed logs land in one
slice whose base instant is the failed one.
`isFileSliceCommitted` only checked whether the base instant itself was
committed, so the whole slice — including its committed log files — was
treated as uncommitted and dropped from the reader view, silently losing
committed data.
Fix: also consider a slice committed when any of its log files carries a
committed delta commit time. Read-side `filterUncommittedFiles` /
`filterUncommittedLogs` still trims the individual uncommitted log, so only
committed logs are read.
The change is inert for table version < 8: there every log file in a slice
shares the slice's base instant as its file-name token, so an uncommitted
base implies all-uncommitted log tokens and the new clause cannot fire.
### Impact
Restores correct MOR read results when a file slice's base instant belongs
to a failed/rolled-back delta commit. No public API change.
### Risk level: low
Narrowly widens slice visibility; covered by two new unit tests and
verified to be a no-op for pre-v8 layouts.
### Documentation Update
None.
### Contributor's checklist
- [x] Read through the [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Change Logs and Impact were stated clearly
- [x] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5618105900
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677",
"triggerID" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"triggerType" : "PUSH"
}, {
"hash" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16864",
"triggerID" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"triggerType" : "PUSH"
}, {
"hash" : "36c2997e9b38465508860c34c5056dc82d2b21c3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16983",
"triggerID" : "36c2997e9b38465508860c34c5056dc82d2b21c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 568666a22fb3ac45f2e1d7eedfabcc3796014e98 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16864)
* 36c2997e9b38465508860c34c5056dc82d2b21c3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16983)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5454008574
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5d425a5513b546266f17e49ba008b573d2b3a22 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #19785:
URL: https://github.com/apache/hudi/pull/19785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #19785:
URL: https://github.com/apache/hudi/pull/19785#discussion_r3978678575
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java:
##########
@@ -160,7 +160,21 @@ private boolean isFileSliceCommitted(FileSlice slice) {
return false;
}
- return timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime());
+ if (timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime())) {
+ return true;
+ }
+
+ // An uncommitted base instant with a base file keeps the original semantics: the slice stays
+ // hidden and is never revived by a committed log, otherwise the uncommitted base file would be
+ // read in full (there is no read-side trimming for it before table version 8).
+ if (slice.getBaseFile().isPresent()) {
Review Comment:
🤖 This thread looks superseded by the force-push: the head commit (36c2997) no longer touches `isFileSliceCommitted` at all — the fix moved into `HoodieFileGroup.addLogFiles`, which seeds the first slice at the earliest *completed* log so the pending one attaches via the existing pending-log rule. The base-file flavour is now an explicit design choice rather than a guard: `testUncommittedBaseFileSliceStaysHiddenDespiteCommittedLogs` asserts that an uncommitted base at t1 plus committed logs t2/t3 stays hidden. Might be worth a line in the PR description noting that the Flink bulk_insert(base) + streaming(log) NBCC case is deliberately left to rollback rather than covered here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5455047815
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677",
"triggerID" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5d425a5513b546266f17e49ba008b573d2b3a22 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5569811344
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677",
"triggerID" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"triggerType" : "PUSH"
}, {
"hash" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16864",
"triggerID" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 568666a22fb3ac45f2e1d7eedfabcc3796014e98 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16864)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #19785:
URL: https://github.com/apache/hudi/pull/19785#discussion_r3948512540
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java:
##########
@@ -160,7 +160,21 @@ private boolean isFileSliceCommitted(FileSlice slice) {
return false;
}
- return timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime());
+ if (timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime())) {
+ return true;
+ }
+
+ // An uncommitted base instant with a base file keeps the original semantics: the slice stays
+ // hidden and is never revived by a committed log, otherwise the uncommitted base file would be
+ // read in full (there is no read-side trimming for it before table version 8).
+ if (slice.getBaseFile().isPresent()) {
+ return false;
+ }
+
+ // Log-only slice: safe to admit once a log is based off a committed instant, the log reader
+ // filters out uncommitted log blocks.
Review Comment:
🤖 I don't think this rationale holds for v8+: both `AbstractHoodieLogRecordScanner` (L331) and `BaseHoodieLogRecordReader` (L302) only skip uncommitted blocks when `tableVersion.lesserThan(EIGHT)`. On v8+ — the only layout where this clause fires — the guarantee comes from the view's `filterUncommittedFiles`/`filterUncommittedLogs`, and APIs that don't trim (`getAllFileSlices(partition)`, `getLatestUnCompactedFileSlices`, `getAllFileGroups`) will now hand out the failed t2 log. Could you double-check that every consumer you rely on goes through the trimming path, and update the comment to reflect the actual invariant?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java:
##########
@@ -160,7 +160,21 @@ private boolean isFileSliceCommitted(FileSlice slice) {
return false;
}
- return timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime());
+ if (timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime())) {
+ return true;
+ }
+
+ // An uncommitted base instant with a base file keeps the original semantics: the slice stays
+ // hidden and is never revived by a committed log, otherwise the uncommitted base file would be
+ // read in full (there is no read-side trimming for it before table version 8).
+ if (slice.getBaseFile().isPresent()) {
Review Comment:
🤖 Does this guard leave the base-file flavour of the same NBCC bug in place? Under NBCC the bucket fileId is deterministic (`newBucketFileIdForNBCC` = bucketId + `CONSTANT_FILE_ID_SUFFIX`, used by Flink `BucketBulkInsertWriterHelper` and Spark `BaseSparkBucketIndexBucketInfoGetter`), so a failed bulk_insert base file at t2 plus committed logs t3/t4 land in one slice that stays hidden here — yet for v8+ `filterUncommittedFiles` already strips the uncommitted base file, so admitting it would be safe. I realise the guard is there for pre-v8 (no base-file trimming), but since this only fires on v8+ layouts anyway, is the extra restriction intended?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5619343504
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677",
"triggerID" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"triggerType" : "PUSH"
}, {
"hash" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16864",
"triggerID" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"triggerType" : "PUSH"
}, {
"hash" : "36c2997e9b38465508860c34c5056dc82d2b21c3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16983",
"triggerID" : "36c2997e9b38465508860c34c5056dc82d2b21c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36c2997e9b38465508860c34c5056dc82d2b21c3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16983)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5454038924
sorry, after some analysis, I found that patch1 is more reasonable fix: https://github.com/apache/hudi/issues/19774#issuecomment-5453997880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5568874857
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677",
"triggerID" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"triggerType" : "PUSH"
}, {
"hash" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16864",
"triggerID" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5d425a5513b546266f17e49ba008b573d2b3a22 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677)
* 568666a22fb3ac45f2e1d7eedfabcc3796014e98 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16864)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5454074578
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677",
"triggerID" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5d425a5513b546266f17e49ba008b573d2b3a22 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5568642725
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677",
"triggerID" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"triggerType" : "PUSH"
}, {
"hash" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5d425a5513b546266f17e49ba008b573d2b3a22 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677)
* 568666a22fb3ac45f2e1d7eedfabcc3796014e98 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5455338857
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 78.15%. Comparing base ([`7b377a5`](https://app.codecov.io/gh/apache/hudi/commit/7b377a51ae1b3727795b73fafae76d7d67d32d90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a5d425a`](https://app.codecov.io/gh/apache/hudi/commit/a5d425a5513b546266f17e49ba008b573d2b3a22?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19785 +/- ##
=========================================
Coverage 78.15% 78.15%
- Complexity 33691 33694 +3
=========================================
Files 2540 2540
Lines 141413 141415 +2
Branches 17123 17124 +1
=========================================
+ Hits 110516 110518 +2
Misses 23195 23195
Partials 7702 7702
```
| [Components](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hudi-common](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.57% <100.00%> (+<0.01%)` | :arrow_up: |
| [hudi-client](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.15% <ø> (ø)` | |
| [hudi-flink](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.66% <ø> (ø)` | |
| [hudi-spark-datasource](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.69% <ø> (ø)` | |
| [hudi-utilities](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.53% <ø> (ø)` | |
| [hudi-cli](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.06% <ø> (ø)` | |
| [hudi-hadoop](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.11% <ø> (ø)` | |
| [hudi-sync](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.56% <ø> (ø)` | |
| [hudi-io](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.85% <ø> (ø)` | |
| [hudi-timeline-service](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.44% <ø> (ø)` | |
| [hudi-cloud](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.81% <ø> (ø)` | |
| [hudi-kafka-connect](https://app.codecov.io/gh/apache/hudi/pull/19785/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.20% <ø> (ø)` | |
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/19785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.03% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/19785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/common/model/HoodieFileGroup.java](https://app.codecov.io/gh/apache/hudi/pull/19785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fmodel%2FHoodieFileGroup.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVHcm91cC5qYXZh) | `100.00% <100.00%> (ø)` | |
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(common): keep committed logs visible under an uncommitted base instant [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19785:
URL: https://github.com/apache/hudi/pull/19785#issuecomment-5618031990
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16677",
"triggerID" : "a5d425a5513b546266f17e49ba008b573d2b3a22",
"triggerType" : "PUSH"
}, {
"hash" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16864",
"triggerID" : "568666a22fb3ac45f2e1d7eedfabcc3796014e98",
"triggerType" : "PUSH"
}, {
"hash" : "36c2997e9b38465508860c34c5056dc82d2b21c3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "36c2997e9b38465508860c34c5056dc82d2b21c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 568666a22fb3ac45f2e1d7eedfabcc3796014e98 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16864)
* 36c2997e9b38465508860c34c5056dc82d2b21c3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org