You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/02/04 16:07:03 UTC
[GitHub] [thrift] belugabehr opened a new pull request #2324: THRIFT-5346: Add prePocess postProcess and errorProcess to Server Con…
belugabehr opened a new pull request #2324:
URL: https://github.com/apache/thrift/pull/2324
…text
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2324: THRIFT-5346: Add prePocess postProcess and errorProcess to Server Con…
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2324:
URL: https://github.com/apache/thrift/pull/2324#issuecomment-773458184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2324: THRIFT-5346: Add prePocess postProcess and errorProcess to Server Con…
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2324:
URL: https://github.com/apache/thrift/pull/2324#issuecomment-773468100
@Jens-G Yes. Renamed one of the methods and added a few more to an Interface, so anyone using this interface will have to updated. I don't know how popular feature it is, from my reading, seems like it was put in for Hive some time ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2324: THRIFT-5346: Add prePocess postProcess and errorProcess to Server Con…
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2324:
URL: https://github.com/apache/thrift/pull/2324#issuecomment-773458184
Is this a breaking change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2324: THRIFT-5346: Add prePocess postProcess and errorProcess to Server Con…
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2324:
URL: https://github.com/apache/thrift/pull/2324#issuecomment-773559714
I'm a bit hesitant about introducing a last minute breaking change. Also CI fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2324: THRIFT-5346: Add prePocess postProcess and errorProcess to Server Con…
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2324:
URL: https://github.com/apache/thrift/pull/2324#issuecomment-773618252
@Jens-G No worries. I was able to work around it well enough. Not a blocker. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2324: THRIFT-5346: Add prePocess postProcess and errorProcess to Server Con…
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2324:
URL: https://github.com/apache/thrift/pull/2324#issuecomment-773468100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2324: THRIFT-5346: Add prePocess postProcess and errorProcess to Server Con…
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2324:
URL: https://github.com/apache/thrift/pull/2324#issuecomment-789149361
Any news here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org