You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/08/11 05:24:45 UTC
Review Request 37335: Fixed scheduler library tests after moving to
http
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37335/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description
-------
We not let the original scheduler know if some other instance of it failed over. Fixed a test to ignore this error event.
Diffs
-----
src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f
Diff: https://reviews.apache.org/r/37335/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37335: Fixed scheduler library tests after moving
to http
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37335/#review94976
-----------------------------------------------------------
src/tests/scheduler_tests.cpp (lines 168 - 170)
<https://reviews.apache.org/r/37335/#comment149715>
IIUC, sending a subscribe call closes the previous reader/stream. How come it receives an error event on the new stream?
- Vinod Kone
On Aug. 11, 2015, 5:40 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37335/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 5:40 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-2552
> https://issues.apache.org/jira/browse/MESOS-2552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We now let the original scheduler know if some other instance of it failed over. Fixed a test to ignore this error event.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f
>
> Diff: https://reviews.apache.org/r/37335/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37335: Fixed scheduler library tests after moving
to http
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37335/
-----------------------------------------------------------
(Updated Aug. 11, 2015, 5:40 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Re-run reviewbot.
Bugs: MESOS-2552
https://issues.apache.org/jira/browse/MESOS-2552
Repository: mesos
Description (updated)
-------
We now let the original scheduler know if some other instance of it failed over. Fixed a test to ignore this error event.
Diffs
-----
src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f
Diff: https://reviews.apache.org/r/37335/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37335: Fixed scheduler library tests after moving
to http
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37335/#review94873
-----------------------------------------------------------
Bad patch!
Reviews applied: [37298, 37300, 37301, 37302]
Failed command: ./support/apply-review.sh -n -r 37302
Error:
2015-08-11 04:33:14 URL:https://reviews.apache.org/r/37302/diff/raw/ [3739/3739] -> "37302.patch" [1]
error: patch failed: src/scheduler/scheduler.cpp:252
error: src/scheduler/scheduler.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Aug. 11, 2015, 3:25 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37335/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 3:25 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-2552
> https://issues.apache.org/jira/browse/MESOS-2552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We not let the original scheduler know if some other instance of it failed over. Fixed a test to ignore this error event.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f
>
> Diff: https://reviews.apache.org/r/37335/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37335: Fixed scheduler library tests after moving
to http
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37335/
-----------------------------------------------------------
(Updated Aug. 11, 2015, 3:25 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Added JIRA link to bugs
Bugs: MESOS-2552
https://issues.apache.org/jira/browse/MESOS-2552
Repository: mesos
Description
-------
We not let the original scheduler know if some other instance of it failed over. Fixed a test to ignore this error event.
Diffs
-----
src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f
Diff: https://reviews.apache.org/r/37335/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar