You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/06/30 22:06:32 UTC
[PR] docs(mcp): add Semantic Layer MCP research spike and implementation plan [superset]
aminghadersohi opened a new pull request, #41594:
URL: https://github.com/apache/superset/pull/41594
### SUMMARY
Research spike mapping out what "Semantic Layer MCP" means for MCP v2, what Superset already covers, and what needs to be built.
Adds `RESEARCH.md` with:
- Analysis of Superset's two semantic layer systems (built-in `SqlaTable` + external `SemanticLayer/SemanticView`)
- Inventory of existing MCP v1 tool coverage
- Q&A with betodealmeida on open design questions (answered 2026-06-04)
- **Final architecture proposal** based on Beto's answers
**Key architectural decisions documented:**
The intended LLM workflow is a flat metric-first pattern (not a hierarchical layer-first discovery flow):
1. `list_metrics` — unified search across built-in + external layers, includes compatible dimensions per metric inline
2. `get_table(metrics, dimensions, filters)` — unified query tool routing to built-in or external path
New tools proposed (in priority order):
| Tool | Phase | Notes |
|---|---|---|
| `list_metrics` | 1 | Primary entry point; spans SqlMetric + SemanticView; no layer selection required |
| `get_table` | 1 | Unified query; replaces separate `query_dataset` + `query_semantic_view` for semantic workflows |
| `get_compatible_dimensions` | 1 | Surfaces `view.get_compatible_dimensions()` from `semantic_layers/view.py` |
| `get_compatible_metrics` | 1 | Surfaces `view.get_compatible_metrics()` |
| `get_dimension_values` | 2 | Surfaces `view.get_values()` — needs Snowflake plugin |
| `get_row_count` | 2 | Surfaces `view.get_row_count()` — needs Snowflake plugin |
| `list_semantic_layers` | 3 | Admin discovery |
| `get_semantic_layer_info` | 3 | Admin discovery |
| `list_semantic_views` | 3 | Admin discovery |
Total estimated effort: ~4 weeks across 3 phases.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — documentation only.
### TESTING INSTRUCTIONS
No code changes. Review `RESEARCH.md` for accuracy of the architecture proposal.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(mcp): add Semantic Layer MCP research spike and implementation plan [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #41594:
URL: https://github.com/apache/superset/pull/41594#issuecomment-5243832245
Phase 1 of this proposal already shipped in #41611 (list_metrics, get_table, get_compatible_dimensions/metrics), so I'll close this research doc as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(mcp): add Semantic Layer MCP research spike and implementation plan [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #41594:
URL: https://github.com/apache/superset/pull/41594#issuecomment-4848315318
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 7c2135a3adb6b72aa72aaef7c386492ef7157814 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a443deef93b2f00086c7726 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-41594--superset-docs-preview.netlify.app](https://deploy-preview-41594--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5QTK0-kHPWNeVgkxZvUj097zNYV4oklNpsANM4AUfOoeFK6PQqSonfNpF6sbOohKV0QKXO_cjjGhxWUxgjpvxc9Rar5acmy18Pw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-41594--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(mcp): add Semantic Layer MCP research spike and implementation plan [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41594:
URL: https://github.com/apache/superset/pull/41594#issuecomment-4848288490
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(mcp): add Semantic Layer MCP research spike and implementation plan [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #41594: docs(mcp): add Semantic Layer MCP research spike and implementation plan
URL: https://github.com/apache/superset/pull/41594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org