You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Aled Sage <no...@github.com> on 2016/06/13 13:16:09 UTC
[jclouds/jclouds-labs] Docker: getting container IPs of container
with network(s) (#284)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/284
-- Commit Summary --
* docker: get container’s IPs from all networks
* Docker.ContainerToNodeMetadata: remove needless mocking
-- File Changes --
M docker/src/main/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadata.java (20)
M docker/src/main/java/org/jclouds/docker/domain/NetworkSettings.java (71)
M docker/src/test/java/org/jclouds/docker/compute/functions/ContainerToNodeMetadataTest.java (74)
M docker/src/test/java/org/jclouds/docker/parse/ContainerParseTest.java (3)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/284.patch
https://github.com/jclouds/jclouds-labs/pull/284.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/284
Re: [jclouds/jclouds-labs] Docker: getting container IPs of container
with network(s) (#284)
Posted by Andrea Turli <no...@github.com>.
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6dcadf1f)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/284#issuecomment-225614020
Re: [jclouds/jclouds-labs] Docker: getting container IPs of container
with network(s) (#284)
Posted by Andrew Donald Kennedy <no...@github.com>.
Looks good @aledsage, just need a version for 1.9.x as well
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/284#issuecomment-225598151
Re: [jclouds/jclouds-labs] Docker: getting container IPs of container
with network(s) (#284)
Posted by Andrew Donald Kennedy <no...@github.com>.
@aledsage yes, it's much nicer, and agree should update master docker DTOs like this
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/284#issuecomment-225603590
Re: [jclouds/jclouds-labs] Docker: getting container IPs of container
with network(s) (#284)
Posted by Andrea Turli <no...@github.com>.
thanks @aledsage, merging now!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/284#issuecomment-225612094
Re: [jclouds/jclouds-labs] Docker: getting container IPs of container
with network(s) (#284)
Posted by Aled Sage <no...@github.com>.
Thanks @andreaturli for pointing out the `@AutoValue.Builder` usage - so much nicer!
We should re-write the other builders (in master, rather than 1.9.x branch I presume) with that pattern as well. But in a separate PR obviously.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/284#issuecomment-225602906
Re: [jclouds/jclouds-labs] Docker: getting container IPs of container
with network(s) (#284)
Posted by Andrea Turli <no...@github.com>.
Closed #284.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/284#event-690591652
Re: [jclouds/jclouds-labs] Docker: getting container IPs of container
with network(s) (#284)
Posted by Andrea Turli <no...@github.com>.
> @@ -59,6 +59,77 @@ public static Details create(String endpointId, String gateway, String ipAddress
> return new AutoValue_NetworkSettings_Details(endpointId, gateway, ipAddress, ipPrefixLen, ipv6Gateway, globalIPv6Address, globalIPv6PrefixLen,
> macAddress);
> }
> +
> + public static Builder builder() {
as you are adding the builders, can you please use [this](https://github.com/google/auto/blob/master/value/userguide/builders.md) ?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/284/files/a29d9bf656929d4b7b6d1a05cd9745618c142b77#r66798886
Re: [jclouds/jclouds-labs] Docker: getting container IPs of container
with network(s) (#284)
Posted by Andrea Turli <no...@github.com>.
minor comment on the builders. thanks @aledsage
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/284#issuecomment-225594885