[Bug 57744] New: [PATCH] getMessageDate returns null when message submission chunk "id" contains hyphen

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57744

            Bug ID: 57744
           Summary: [PATCH] getMessageDate returns null when message
                    submission chunk "id" contains hyphen
           Product: POI
           Version: 3.10-FINAL
          Hardware: PC
            Status: NEW
          Keywords: PatchAvailable
          Severity: normal
          Priority: P2
         Component: HSMF
          Assignee: dev@poi.apache.org
          Reporter: adrian.conlon@arup.com

The current date parser within MessageSubmissionChunk.java sees the id as
containing:
  l=<id>-<time>-<number>

This is almost correct, but the id normally seems to be a hostname of a what
appears to be a mail relay.  Hostnames can contain hyphens which seems to be
confusing the code that extracts the date/time to be parsed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 57744] [PATCH] getMessageDate returns null when message submission chunk "id" contains hyphen

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57744

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Dominik Stadler <do...@gmx.at> ---
Submitted via r1688998

Note that I reworked it a bit to avoid unnecessary creation of empty String and
to avoid creating multiple intermediate strings when lastIndexOf() has a way to
start looking at some index already.

Also avoided a border-case where only one hyphen in the string would break
substring()

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 57744] [PATCH] getMessageDate returns null when message submission chunk "id" contains hyphen

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57744

--- Comment #1 from Adrian Conlon <ad...@arup.com> ---
Created attachment 32594
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32594&action=edit
Proposed patch

Reimplement part of MessageSubmissionChunk.java, readValue to get the date bit
of the submission string in a different way.

Basically, works backwards from the end of the string to find delimiting
hyphens.

Two test cases added: One with a hyphen in the id part of the submission chunk;
the other without.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org