You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/19 12:16:17 UTC

[GitHub] [arrow-datafusion] alamb edited a comment on pull request #1607: consolidate binary_expr coercion rule code

alamb edited a comment on pull request #1607:
URL: https://github.com/apache/arrow-datafusion/pull/1607#issuecomment-1016381999


   > I think it's my fault and leave some duplicated code.
   > My original thought is that I will consolidate binary logic and coercion in the follow-up pull-requests.
   
   No worries @liukun4515  -- you said that. I just figured I was already changing the code for #1606  so I would make progress here too
   
   Also note there is no actual consolidation of the logic -- I just moved the code to the same module. I envision your cleanup to consolidate the actual logic would be in a follow on PR 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org