You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/01/06 20:43:33 UTC

Re: Review Request 16392: TR1 check within the autoconf phase

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16392/#review31251
-----------------------------------------------------------

Ship it!



configure.ac
<https://reviews.apache.org/r/16392/#comment59651>

    When we _require_ C++11, we would be removing this in favor of a C++11 check instead, right?


- Ben Mahler


On Dec. 21, 2013, 4:36 p.m., TILL TOENSHOFF wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16392/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2013, 4:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-706
>     https://issues.apache.org/jira/browse/MESOS-706
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Adds a check for TR1 within the autoconf phase (AC_HEADER_STDCXX_TR1) and simply errors out if that fails. Users are advised to use at least gcc 4.0 for getting over that hurdle.
> 
> 
> Diffs
> -----
> 
>   configure.ac f69908a 
>   m4/ax_cxx_header_stdcxx_tr1.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16392/diff/
> 
> 
> Testing
> -------
> 
> ./bootstrap ./configure (with and without TR1 headers available)
> 
> 
> Thanks,
> 
> TILL TOENSHOFF
> 
>