You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2020/07/22 00:44:05 UTC
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16231
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
This JIRA could be considered as a follow-up to IMPALA-9625, where we
converted the name of a TAccessEvent to lowercase to avoid duplicate
audits in the Set used to maintain the collected TAccessEvent's so that
there will not be duplicate TAccessEvent's in the file specified by the
flag of "-audit_event_log_dir" when Impala is started.
However, the patch for IMPALA-9625 only considered the audits that are
exported to the specific file mentioned above but not the
PrivilegeRequest's that will be processed by Ranger which in turn would
produce the corresponding audit log entries. Therefore, the
fully-qualified table name that is provided when
Analyzer#registerPrivReq() is called in Analyzer#getTable() is not
necessarily in lowercase, resulting in duplicate AuthzAuditEvent's
stored in the corresponding RangerBufferAuditHandler because the
full table names returned from registerAuthAndAuditEvent() and
getTable() differ. Refer to IMPALA-9625 for more details.
To resolve the inconsistencies, this patch converts the arguments of
database and table names to lowercase when
PrivilegeRequestBuilder#onTable() is building the corresponding
PrivilegeRequest, which will later be added to the Set of
PrivilegeRequest's for Ranger to process.
Testing:
- Added an FE test in RangerAuditLogTest.java to make sure no duplicate
Ranger audit log entries are produced.
Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
---
M fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java
M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
2 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/16231/1
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
This JIRA could be considered as a follow-up to IMPALA-9625, where we
converted the name of a TAccessEvent to lowercase to avoid duplicate
audits in the Set used to maintain the collected TAccessEvent's so that
there will not be duplicate TAccessEvent's in the file specified by the
flag of "-audit_event_log_dir" when Impala is started.
However, the patch for IMPALA-9625 only considered the audits that are
exported to the specific file mentioned above but not the
PrivilegeRequest's that will be processed by Ranger which in turn would
produce the corresponding audit log entries. Therefore, the
fully-qualified table name that is provided when
Analyzer#registerPrivReq() is called in Analyzer#getTable() is not
necessarily in lowercase, resulting in duplicate AuthzAuditEvent's
stored in the corresponding RangerBufferAuditHandler because the
full table names returned from registerAuthAndAuditEvent() and
getTable() differ. Refer to IMPALA-9625 for more details.
To resolve the inconsistencies, this patch converts the arguments of
database and table names to lowercase when
PrivilegeRequestBuilder#onTable() is building the corresponding
PrivilegeRequest, which will later be added to the Set of
PrivilegeRequest's for Ranger to process.
Testing:
- Added an FE test in RangerAuditLogTest.java to make sure no duplicate
Ranger audit log entries are produced.
- Verified that the patch passes the exhaustive tests in the DEBUG
build.
Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
---
M fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java
M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
2 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/16231/2
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
This JIRA could be considered as a follow-up to IMPALA-9625, where we
converted the name of a TAccessEvent to lowercase to avoid duplicate
audits in the Set used to maintain the collected TAccessEvent's so that
there will not be duplicate TAccessEvent's in the file specified by the
flag of "-audit_event_log_dir" when Impala is started.
However, the patch for IMPALA-9625 only considered the audits that are
exported to the specific file mentioned above but not the
PrivilegeRequest's that will be processed by Ranger which in turn would
produce the corresponding audit log entries. Therefore, the
fully-qualified table name that is provided when
Analyzer#registerPrivReq() is called in Analyzer#getTable() is not
necessarily in lowercase, resulting in duplicate AuthzAuditEvent's
stored in the corresponding RangerBufferAuditHandler because the
full table names returned from registerAuthAndAuditEvent() and
getTable() differ. Refer to IMPALA-9625 for more details.
To resolve the inconsistencies, this patch converts the arguments of
database and table names to lowercase when
PrivilegeRequestBuilder#onTable() is building the corresponding
PrivilegeRequest, which will later be added to the Set of
PrivilegeRequest's for Ranger to process.
Testing:
- Added an FE test in RangerAuditLogTest.java to make sure no duplicate
Ranger audit log entries are produced.
- Verified that the patch passes the exhaustive tests in the DEBUG
build.
Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Reviewed-on: http://gerrit.cloudera.org:8080/16231
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/authorization/PrivilegeRequestBuilder.java
M fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
2 files changed, 18 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Jul 2020 00:38:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 01:55:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16231/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16231/1//COMMIT_MSG@7
PS1, Line 7: ALTER
> Thanks Quanlong for the prompt reply! I actually have not checked this for
Yeah, a follow-up jira looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Jul 2020 00:35:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1: Code-Review+2
>
> Oops, don't mean to remove the +2...
Not a problem at all. :-) This patch is still being tested by a Jenkins job to make sure there is no regression after applying the proposed changes. Will update you on this after the result of testing is known.
http://gerrit.cloudera.org:8080/#/c/16231/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16231/1//COMMIT_MSG@7
PS1, Line 7: ALTER
> Does this only happen on ALTER events? Or other queries have uppercase tabl
Thanks Quanlong for the prompt reply! I actually have not checked this for all other types of statements. I think it may be good to create a follow-up JIRA to investigate this.
What I am sure of now is that for an existing table, the registration of PrivilegeRequest for ALTER would occur twice. One in Analyzer#registerAuthAndAuditEvent() (https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/analysis/Analyzer.java#L3155-L3161) and the other in Analyzer#getTable() (https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/analysis/Analyzer.java#L2860-L2872).
On the other hand, for a non-existing table, there could be 1 or 2 registrations for ALTER depending on the size of 'rawPath' (https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/analysis/Analyzer.java#L734-L752).
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 06:01:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6694/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 23:51:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6686/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 01:08:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Jul 2020 05:49:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6177/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Jul 2020 00:38:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 1: -Code-Review
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16231/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16231/1//COMMIT_MSG@7
PS1, Line 7: ALTER
Does this only happen on ALTER events? Or other queries have uppercase table names also suffer the same issue?
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 01:57:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16231 )
Change subject: IMPALA-9977: Remove duplicate Ranger audit log entries for ALTER events
......................................................................
Patch Set 1: Code-Review+2
Oops, don't mean to remove the +2...
--
To view, visit http://gerrit.cloudera.org:8080/16231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9b664ad5ee9722182007ee67d14bf47bd03d8a
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 01:58:36 +0000
Gerrit-HasComments: No