Re: [PR] [Policy Store] Add policyTypeCode to Slice/Index for Future Filtering Support and Update Policy Persistence Method [polaris]

["dimas-b (via GitHub)" <gi...@apache.org>]

dimas-b commented on code in PR #1628:
URL: https://github.com/apache/polaris/pull/1628#discussion_r2098832226


##########
extension/persistence/jpa-model/src/main/java/org/apache/polaris/jpa/models/ModelPolicyMappingRecord.java:
##########
@@ -33,7 +33,7 @@
     indexes = {
       @Index(
           name = "POLICY_MAPPING_RECORDS_BY_POLICY_INDEX",
-          columnList = "policyCatalogId,policyId,targetCatalogId,targetId")
+          columnList = "policyTypeCode,policyCatalogId,policyId,targetCatalogId,targetId")

Review Comment:
   I'm not sure it's worth bothering with EclipseLink support for new features since EclipseLink is deprecated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org