Re: [PR] [SPARK-40876][SQL][TESTS][FOLLOWUP] Skip the test inputs in `ParquetTypeWideningSuite` that violate the data type conversion rules under ANSI mode [spark]

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #44481:
URL: https://github.com/apache/spark/pull/44481#discussion_r1436052374


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTypeWideningSuite.scala:
##########
@@ -166,11 +166,17 @@ class ParquetTypeWideningSuite
       (Seq("1", "2", Int.MinValue.toString), LongType, IntegerType),
       (Seq("1.23", "10.34"), DoubleType, FloatType),
       (Seq("1.23", "10.34"), FloatType, LongType),
-      (Seq("1.23", "10.34"), LongType, DateType),
-      (Seq("1.23", "10.34"), IntegerType, TimestampType),
-      (Seq("1.23", "10.34"), IntegerType, TimestampNTZType),
       (Seq("2020-01-01", "2020-01-02", "1312-02-27"), DateType, TimestampType)
-    )
+    ) ++ {
+      if (SQLConf.get.ansiEnabled) Nil

Review Comment:
   It seems that only the test cases used the input test data that would fail to type conversion when ANSI MODE is set to true when constructing test cases that `would throw errors when read`. In this PR, To quickly fix , I have skipped these three test inputs
   
   @cloud-fan @zhengruifeng FYI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org