You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 12:38:44 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #1331: Cleanup: remove some dead / test only code
alamb opened a new pull request #1331:
URL: https://github.com/apache/arrow-rs/pull/1331
# Which issue does this PR close?
Re https://github.com/apache/arrow-rs/issues/1255
# Rationale for this change
There was some code discovered by clippy in https://github.com/apache/arrow-rs/pull/1324 that was legitimately dead.
# What changes are included in this PR?
Remove a unused / private function and move a function used only by tests to the test module
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #1331: Cleanup: remove some dead / test only code
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1331:
URL: https://github.com/apache/arrow-rs/pull/1331#discussion_r809004551
##########
File path: arrow/src/compute/util.rs
##########
@@ -58,41 +58,6 @@ pub(super) fn combine_option_bitmap(
}
}
-/// Compares the null bitmaps of two arrays using a bitwise `or` operation.
-///
-/// This function is useful when implementing operations on higher level arrays.
-#[allow(clippy::unnecessary_wraps)]
Review comment:
this was only used in the tests, so I moved it to the test module in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1331: Cleanup: remove some dead / test only code
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1331:
URL: https://github.com/apache/arrow-rs/pull/1331#issuecomment-1042920003
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1331](https://codecov.io/gh/apache/arrow-rs/pull/1331?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22fbfc1) into [master](https://codecov.io/gh/apache/arrow-rs/commit/9870533a0bade006bab9cf479c9dac2fee809087?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9870533) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1331 +/- ##
=======================================
Coverage 83.03% 83.03%
=======================================
Files 180 180
Lines 52919 52915 -4
=======================================
- Hits 43939 43938 -1
+ Misses 8980 8977 -3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/data.rs](https://codecov.io/gh/apache/arrow-rs/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2RhdGEucnM=) | `83.59% <ø> (+0.29%)` | :arrow_up: |
| [arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow-rs/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUvdXRpbC5ycw==) | `98.90% <100.00%> (ø)` | |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.21% <0.00%> (-0.23%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1331?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1331?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9870533...22fbfc1](https://codecov.io/gh/apache/arrow-rs/pull/1331?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] nevi-me merged pull request #1331: Cleanup: remove some dead / test only code
Posted by GitBox <gi...@apache.org>.
nevi-me merged pull request #1331:
URL: https://github.com/apache/arrow-rs/pull/1331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org