Re: [PR] KAFKA-17207: Recreate config topic in Connect test to prevent thread … [kafka]

["mimaison (via GitHub)" <gi...@apache.org>]

mimaison commented on code in PR #20307:
URL: https://github.com/apache/kafka/pull/20307#discussion_r2681776801


##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##########
@@ -867,6 +867,9 @@ public void testRequestTimeouts() throws Exception {
                 "writing a config for connector " + CONNECTOR_NAME + " to the config topic",
                 false
         );
+
+        // Fix for KAFKA-17103: Recreate the config topic to allow producer shutdown and avoid thread leak
+        connect.kafka().createTopic(configTopic);

Review Comment:
   Should we put this in a `finally` block so it runs even if one of the assertions above fails?
   
   Also let's remove the reference to the Jira in the comment as it's not helpful. Image if every fix had a comment to a Jira, these would be everywhere in the code base!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org