You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by chiwanpark <gi...@git.apache.org> on 2016/01/14 10:13:30 UTC
[GitHub] flink pull request: [FLINK-2984] [ml] Extend libSVM file format su...
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/1504
[FLINK-2984] [ml] Extend libSVM file format support
Currently, FlinkML libSVM file reader cannot read some datasets (such as splice-site) in libSVM official site. This PR extends libSVM file format to liblinear equivalent. To avoid re-compiling regex pattern in every line, I changed the mapper from scala lambda function to `RichFlatMapFunction`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chiwanpark/flink FLINK-2984
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1504.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1504
----
commit 200e8335ff157cb621fa9d385ebb36531de3bd68
Author: Chiwan Park <ch...@apache.org>
Date: 2016-01-13T08:34:11Z
[FLINK-2984] [ml] Extend libSVM file format support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2984] [ml] Extend libSVM file format su...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1504#issuecomment-171583921
Changes look good. +1 for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2984] [ml] Extend libSVM file format su...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1504
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2984] [ml] Extend libSVM file format su...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1504#issuecomment-171835207
Thanks for review @tillrohrmann! I'll merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---