[jira] [Commented] (HUDI-3890) Fix apache rat check to detect all missing license

["sivabalan narayanan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HUDI-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537027#comment-17537027 ] 

sivabalan narayanan commented on HUDI-3890:
-------------------------------------------

looks like we exclude the sql files from license check.

 
{code:java}
          <licenseFamilies>
              <licenseFamily implementation="org.apache.rat.license.SimpleLicenseFamily">
                <familyName>Apache License 2.0</familyName>
              </licenseFamily>
            </licenseFamilies>
            <excludes>
              <exclude>NOTICE</exclude>
              <exclude>DISCLAIMER</exclude>
              <exclude>**/.*</exclude>
              <exclude>**/*.json</exclude>
              <exclude>**/*.hfile</exclude>
              <exclude>**/*.log</exclude>
              <exclude>**/*.sqltemplate</exclude>
              <exclude>**/compose_env</exclude>
              <exclude>**/*NOTICE*</exclude>
              <exclude>**/*LICENSE*</exclude>
              <exclude>**/dependency-reduced-pom.xml</exclude>
              <exclude>**/test/resources/*.data</exclude>
              <exclude>**/test/resources/*.commit</exclude>
              <exclude>**/target/**</exclude>
              <exclude>**/generated-sources/**</exclude>
              <exclude>.github/**</exclude>
              <exclude>**/*.sql</exclude>
              <!-- local files not in version control -->
              <exclude>**/*.iml</exclude>
              <exclude>.mvn/**</exclude> {code}
last but 3rd line. 

 

so, we should be good here.

> Fix apache rat check to detect all missing license
> --------------------------------------------------
>
>                 Key: HUDI-3890
>                 URL: https://issues.apache.org/jira/browse/HUDI-3890
>             Project: Apache Hudi
>          Issue Type: Task
>            Reporter: Raymond Xu
>            Priority: Critical
>             Fix For: 0.11.1
>
>
> these 2 files which didn't have license were not reported
> ./hudi-utilities/src/test/resources/delta-streamer-config/schema_registry.source_schema_tab.sql
> ./hudi-utilities/src/test/resources/delta-streamer-config/schema_registry.target_schema_tab.sql



--
This message was sent by Atlassian Jira
(v8.20.7#820007)