You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/12/06 15:39:05 UTC

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

PierreSmits opened a new pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391


   Removing unused labels from AccountingUiLabels.xml
   
   Checked screens, forms, templates, scripts and java code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux merged pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-987893446


   Pierre,
   
   Today I asked myself (again): "Some efforts have been done to produce those. Are we sure we want to remove them? This does not break anything and can still be used in projects that could be updated and missing these labels." 
   
   I then checked, we had this discussion many time already (mostly, in order of appeareance):
   https://markmail.org/message/so4gyq6ph4udh6cm (2016)
   https://issues.apache.org/jira/browse/OFBIZ-8154 (2016)
   https://issues.apache.org/jira/browse/OFBIZ-9352 (2017)
   https://issues.apache.org/jira/browse/OFBIZ-10565 (2018 umbrella task)
   https://markmail.org/message/7kckrtpzw5r7fvkl (2020)
   
   After that I decided to apply what we discussed before: check if it's not used anywhere, then remove. I'm still not sure it's the best decision, but it's the one we decided on.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-988067070


   Yes, we can always revert (easy with labels, not much changes now).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-986894935


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=391) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=391&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-987908621


   Hi Jacques,
   
   Thank you for taking the time to look back, and see why something came about to be. 
   
   These things, like so many others in the codebase, came to be in there (and this is not to lay blame, just an observation), because at the time it seemed appropriate to bring them in and intended - most probably - to be followed up by the contributor in a next ticket. Or maybe it was part of an implementation at a user's site, but the rest was not allowed to go into the project's codebase or forgotten. But you know, life gets in the way or career takes a turn. 
   
   And the good thing is, nothing is ever lost. So we can clean up when not used together with something else in OFBiz. And if in future some other contributor can make a case for an improvement and bring a past included and removed code element back, good for for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux edited a comment on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-987893446


   Pierre,
   
   Today I asked myself (again): "Some efforts have been done to produce those. Are we sure we want to remove them? This does not break anything and can still be used in projects that could be updated and missing these labels." 
   
   I then checked, we had this discussion many time already (mostly, in order of appearance):
   https://markmail.org/message/so4gyq6ph4udh6cm (2016)
   https://issues.apache.org/jira/browse/OFBIZ-8154 (2016)
   https://issues.apache.org/jira/browse/OFBIZ-9352 (2017)
   https://issues.apache.org/jira/browse/OFBIZ-10565 (2018 umbrella task)
   https://markmail.org/message/7kckrtpzw5r7fvkl (2020)
   
   After that I decided to apply what we discussed before: check if it's not used anywhere, then remove. I'm still not sure it's the best decision, but it's the one we decided on.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org