You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Guosmilesmile (via GitHub)" <gi...@apache.org> on 2026/04/16 03:50:14 UTC

[PR] Data: Clean engineProjection in BaseFormatModelTests [iceberg]

Guosmilesmile opened a new pull request, #15995:
URL: https://github.com/apache/iceberg/pull/15995

   After https://github.com/apache/iceberg/pull/15688, format-model writers can now handle cases where engineSchema is not set, so engineProjection is no longer needed and can be removed.
   
   This PR also cleans up some unused code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Data: Clean engineProjection in BaseFormatModelTests [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #15995:
URL: https://github.com/apache/iceberg/pull/15995#issuecomment-4259690627

   Merged to main.
   Thanks @Guosmilesmile for the PR and @rashworld-max for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Data: Clean engineProjection in BaseFormatModelTests [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #15995:
URL: https://github.com/apache/iceberg/pull/15995#discussion_r3090683946


##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -134,12 +134,7 @@ void testDataWriterEngineWriteGenericRead(FileFormat fileFormat, DataGenerator d
     FileWriterBuilder<DataWriter<T>, Object> writerBuilder =
         FormatModelRegistry.dataWriteBuilder(fileFormat, engineType(), encryptedFile);
 
-    DataWriter<T> writer =
-        writerBuilder
-            .schema(schema)
-            .engineSchema(engineSchema(schema))

Review Comment:
   I think .engineSchema(engineSchema(schema)) is the same part, so remove it. Need some review .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Data: Clean engineProjection in BaseFormatModelTests [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #15995:
URL: https://github.com/apache/iceberg/pull/15995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org