You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by pi...@apache.org on 2021/03/16 06:26:17 UTC

[submarine] branch master updated: SUBMARINE-767. Fix link error

This is an automated email from the ASF dual-hosted git repository.

pingsutw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new a4b4e37  SUBMARINE-767. Fix link error
a4b4e37 is described below

commit a4b4e37d832e3270ee16c9c1f296dcb58a328e1e
Author: Lisa <30...@users.noreply.github.com>
AuthorDate: Sun Mar 14 22:48:02 2021 +0800

    SUBMARINE-767. Fix link error
    
    ### What is this PR for?
    Fix some link error in docs
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/SUBMARINE-767
    
    ### How should this be tested?
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Lisa <30...@users.noreply.github.com>
    
    Signed-off-by: Kevin <pi...@apache.org>
    
    Closes #538 from aeioulisa/SUBMARINE-767 and squashes the following commits:
    
    b91b71e2 [Lisa] Update notebook-implementation.md
    2215725d [Lisa] Fix link error in implementation-notes.md
---
 website/docs/designDocs/implementation-notes.md    | 16 ++++++++--------
 website/docs/designDocs/notebook-implementation.md |  4 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/website/docs/designDocs/implementation-notes.md b/website/docs/designDocs/implementation-notes.md
index 23baddb..7ebb996 100644
--- a/website/docs/designDocs/implementation-notes.md
+++ b/website/docs/designDocs/implementation-notes.md
@@ -17,17 +17,17 @@ title: Implementation Notes
    limitations under the License.
 -->
 
-Before digging into details of implementations, you should read [architecture-and-requirements](./architecture-and-requirements) first to understand overall requirements and architecture.
+Before digging into details of implementations, you should read [architecture-and-requirements](./architecture-and-requirements.md) first to understand overall requirements and architecture.
 
 Here're sub topics of Submarine implementations:
 
-- [Submarine Storage](./storage-implementation): How to store metadata, logs, metrics, etc. of Submarine.
-- [Submarine Environment](./environments-implementation): How environments created, managed, stored in Submarine. 
-- [Submarine Experiment](./experiment-implementation): How experiments managed, stored, and how the predefined experiment template works.
-- [Submarine Notebook](./notebook-implementation): How experiments managed, stored, and how the predefined experiment template works.
-- [Submarine Server](./submarine-server/architecture): How Submarine server is designed, architecture, implementation notes, etc.
+- [Submarine Storage](./storage-implementation.md): How to store metadata, logs, metrics, etc. of Submarine.
+- [Submarine Environment](./environments-implementation.md): How environments created, managed, stored in Submarine. 
+- [Submarine Experiment](./experiment-implementation.md): How experiments managed, stored, and how the predefined experiment template works.
+- [Submarine Notebook](./notebook-implementation.md): How experiments managed, stored, and how the predefined experiment template works.
+- [Submarine Server](./submarine-server/architecture.md): How Submarine server is designed, architecture, implementation notes, etc.
 
 Working-in-progress designs, Below are designs which are working-in-progress, we will move them to the upper section once design & review is finished: 
 
-- [Submarine HA Design](./wip-designs/Submarine-clusterServer): How Submarine HA can be achieved, using RAFT, etc.
-- [Submarine services deployment module:](./wip-designs/submarine-launcher) How to deploy submarine services to k8s, YARN or cloud. 
\ No newline at end of file
+- [Submarine HA Design](./wip-designs/submarine-clusterServer.md): How Submarine HA can be achieved, using RAFT, etc.
+- [Submarine services deployment module:](./wip-designs/submarine-launcher.md) How to deploy submarine services to k8s, YARN or cloud. 
diff --git a/website/docs/designDocs/notebook-implementation.md b/website/docs/designDocs/notebook-implementation.md
index fb73760..88afcab 100644
--- a/website/docs/designDocs/notebook-implementation.md
+++ b/website/docs/designDocs/notebook-implementation.md
@@ -104,10 +104,10 @@ Submarine Server IP will be configured automatically by Submarine Server, and ad
 
 ### Security 
 
-Please refer to [Security Implementation](./wip-designs/security-implementation)
+Please refer to [Security Implementation](./wip-designs/security-implementation.md)
 
 Once user accessed to a running notebook session, the user can also access resources of the notebook, capability of submit new experiment, and access data. This is also very dangerous so we have to protect it. 
 
 A simple solution is to use token-based authentication https://jupyter-notebook.readthedocs.io/en/stable/security.html. A more common way is to use solutions like KNOX to support SSO. 
 
-We need expand this section to more details. (TODO).
\ No newline at end of file
+We need expand this section to more details. (TODO).


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org