You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/08/27 13:34:11 UTC
[GitHub] [accumulo] dlmarion opened a new pull request #2249: Re-check for CompactionService when compact called and service does not yet exist
dlmarion opened a new pull request #2249:
URL: https://github.com/apache/accumulo/pull/2249
Closes #2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #2249: Re-check for CompactionService when compact called and service does not yet exist
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #2249:
URL: https://github.com/apache/accumulo/pull/2249#discussion_r697503897
##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/CompactionManager.java
##########
@@ -351,11 +354,12 @@ public void compactableChanged(Compactable compactable) {
compactablesToCheck.add(compactable);
}
- private void checkForConfigChanges() {
+ private synchronized void checkForConfigChanges(boolean force) {
try {
- if (TimeUnit.SECONDS.convert(System.nanoTime() - lastConfigCheckTime, TimeUnit.NANOSECONDS)
- < 1)
+ if (!force && (TimeUnit.SECONDS.convert(System.nanoTime() - lastConfigCheckTime,
+ TimeUnit.NANOSECONDS) < 1)) {
Review comment:
I know this is checking time since lastConfigCheckTime but I think doing the conversion in the boolean makes it hard to read. Would be nice to have another variable like `secondsSinceLastCheck` set before the check so it reads easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on a change in pull request #2249: Re-check for CompactionService when compact called and service does not yet exist
Posted by GitBox <gi...@apache.org>.
Manno15 commented on a change in pull request #2249:
URL: https://github.com/apache/accumulo/pull/2249#discussion_r697511774
##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/CompactionManager.java
##########
@@ -295,13 +295,16 @@ private void compact(Compactable compactable) {
var csid = compactable.getConfiguredService(ctype);
var service = services.get(csid);
if (service == null) {
- log.error(
- "Tablet {} returned non existant compaction service {} for compaction type {}. Check"
- + " the table compaction dispatcher configuration. Attempting to fall back to "
- + "{} service.",
- compactable.getExtent(), csid, ctype, DEFAULT_SERVICE);
-
- service = services.get(DEFAULT_SERVICE);
+ checkForConfigChanges(true);
+ service = services.get(csid);
+ if (service == null) {
+ log.error(
+ "Tablet {} returned non existant compaction service {} for compaction type {}. Check"
Review comment:
```suggestion
"Tablet {} returned non existent compaction service {} for compaction type {}. Check"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #2249: Re-check for CompactionService when compact called and service does not yet exist
Posted by GitBox <gi...@apache.org>.
dlmarion merged pull request #2249:
URL: https://github.com/apache/accumulo/pull/2249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org