[GitHub] [airflow] jedcunningham commented on a diff in pull request #26603: Add unit test for log retrieval url

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #26603:
URL: https://github.com/apache/airflow/pull/26603#discussion_r978012468


##########
airflow/utils/log/file_task_handler.py:
##########
@@ -266,6 +263,14 @@ def _read(self, ti: TaskInstance, try_number: int, metadata: dict[str, Any] | No
 
         return log, {'end_of_log': end_of_log, 'log_pos': log_pos}
 
+    @staticmethod
+    def _get_log_retrieval_url(ti: TaskInstance, log_relative_path: str):

Review Comment:
   ```suggestion
       def _get_log_retrieval_url(ti: TaskInstance, log_relative_path: str) -> str:
   ```
   
   nit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org