You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/10/19 11:36:26 UTC
[GitHub] [incubator-inlong] ruanwenjun opened a new pull request #1679: [INLONG-1628][website] Remove commitlint, husky, cz-conventional-chan…
ruanwenjun opened a new pull request #1679:
URL: https://github.com/apache/incubator-inlong/pull/1679
close #1628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #1679: [INLONG-1628][website] Remove commitlint, husky, cz-conventional-chan…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1679:
URL: https://github.com/apache/incubator-inlong/pull/1679#issuecomment-946640943
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1679](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75ec2cf) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/b3566e144054475494b5b9ffcf25507c2c3869db?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b3566e1) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1679 +/- ##
=========================================
Coverage 12.20% 12.20%
Complexity 1050 1050
=========================================
Files 392 392
Lines 32755 32755
Branches 5159 5159
=========================================
Hits 3997 3997
Misses 27993 27993
Partials 765 765
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b3566e1...75ec2cf](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] leezng commented on a change in pull request #1679: [INLONG-1628][website] Remove commitlint, husky, cz-conventional-chan…
Posted by GitBox <gi...@apache.org>.
leezng commented on a change in pull request #1679:
URL: https://github.com/apache/incubator-inlong/pull/1679#discussion_r732358885
##########
File path: inlong-website/package.json
##########
@@ -54,25 +54,7 @@
]
},
"pre-commit": "lint-staged",
- "husky": {
- "hooks": {
- "pre-commit": "lint-staged",
Review comment:
I saw that the hooks related to eslint have also been removed here. These may be useful. Is it enough to remove only the commit lint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #1679: [INLONG-1628][website] Remove commitlint, husky, cz-conventional-chan…
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #1679:
URL: https://github.com/apache/incubator-inlong/pull/1679#issuecomment-946649519
@leezng PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] ruanwenjun commented on a change in pull request #1679: [INLONG-1628][website] Remove commitlint, husky, cz-conventional-chan…
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #1679:
URL: https://github.com/apache/incubator-inlong/pull/1679#discussion_r732678132
##########
File path: inlong-website/package.json
##########
@@ -54,25 +54,7 @@
]
},
"pre-commit": "lint-staged",
- "husky": {
- "hooks": {
- "pre-commit": "lint-staged",
Review comment:
Thanks for your review, I have revert the change of husky, and just remove commitlint and cz-conventional-changelog, please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #1679: [INLONG-1628][website] Remove commitlint, cz-conventional-changelog
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1679:
URL: https://github.com/apache/incubator-inlong/pull/1679#issuecomment-946640943
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1679](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2609a56) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/b3566e144054475494b5b9ffcf25507c2c3869db?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b3566e1) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1679 +/- ##
============================================
+ Coverage 12.20% 12.22% +0.02%
Complexity 1050 1050
============================================
Files 392 392
Lines 32755 32755
Branches 5159 5159
============================================
+ Hits 3997 4004 +7
+ Misses 27993 27987 -6
+ Partials 765 764 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-inlong/pull/1679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29ubmVjdG9ycy90dWJlbXEtY29ubmVjdG9yLWZsdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9mbHVtZS9zaW5rL3R1YmVtcS9UdWJlbXFTaW5rLmphdmE=) | `55.42% <0.00%> (+4.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b3566e1...2609a56](https://codecov.io/gh/apache/incubator-inlong/pull/1679?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #1679: [INLONG-1628][website] Remove commitlint, cz-conventional-changelog
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #1679:
URL: https://github.com/apache/incubator-inlong/pull/1679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org