You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/19 08:45:10 UTC

[GitHub] [spark-docker] Yikun opened a new pull request, #16: [SPARK-40845] Add template support for SPARK_GPG_KEY and fix GPG verify

Yikun opened a new pull request, #16:
URL: https://github.com/apache/spark-docker/pull/16

   ### What changes were proposed in this pull request?
   This patch:
   - Add template support for `SPARK_GPG_KEY`. 
   - Fix a bug on GPG verified. (Change `||` to `;`)
   
   ### Why are the changes needed?
   Each version have specific GPG key to verified, so we need to set GPG version separately.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   CI passed
   Run `./add-dockerfiles.sh 3.3.0` and see GPG set correctly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark-docker] Yikun commented on pull request #16: [SPARK-40845] Add template support for SPARK_GPG_KEY and fix GPG verify

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #16:
URL: https://github.com/apache/spark-docker/pull/16#issuecomment-1283651939

   ```
   $ gpg --keyserver hkps://keyserver.ubuntu.com --recv-keys 80FB8EBE8EBA68504989703491B5DC815DBF10D3
   gpg: keyserver receive failed: No data
   ```
   
   This patch is failed due to @MaxGekk gpg key (3.3.0 release manager) haven't be imported. But for other release, such as 3.3.1-rc it's OK.
   
   I'm not sure how to import them, maybe @HyukjinKwon know?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark-docker] Yikun closed pull request #16: [SPARK-40845] Add template support for SPARK_GPG_KEY and fix GPG verify

Posted by GitBox <gi...@apache.org>.
Yikun closed pull request #16: [SPARK-40845] Add template support for SPARK_GPG_KEY and fix GPG verify
URL: https://github.com/apache/spark-docker/pull/16


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark-docker] Yikun commented on pull request #16: [SPARK-40845] Add template support for SPARK_GPG_KEY and fix GPG verify

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #16:
URL: https://github.com/apache/spark-docker/pull/16#issuecomment-1285080834

   @martin-g @zhengruifeng @holdenk Thanks all, merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark-docker] Yikun commented on pull request #16: [SPARK-40845] Add template support for SPARK_GPG_KEY and fix GPG verify

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #16:
URL: https://github.com/apache/spark-docker/pull/16#issuecomment-1283654453

   Also cc @holdenk , she found the GPG key is hard code and send a mail to me, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark-docker] Yikun commented on pull request #16: [SPARK-40845] Add template support for SPARK_GPG_KEY and fix GPG verify

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #16:
URL: https://github.com/apache/spark-docker/pull/16#issuecomment-1284864479

   cc @HyukjinKwon @zhengruifeng Ready to go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org