You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2024/12/05 17:36:06 UTC
[I] doc-gen: Migrate builtin functions from code based documentation to attribute based [datafusion]
comphead opened a new issue, #13671:
URL: https://github.com/apache/datafusion/issues/13671
### Is your feature request related to a problem or challenge?
It is needed to migrate whenever it is possible builtin UDF documentation from code based to attribute based.
Function list can be found in `SessionStateDefaults::default_scalar_functions()`
Example can be found https://github.com/apache/datafusion/pull/13646/files#diff-1528bf73810e3fb12fd1d4e76a8b46acb650549ef37d3c131464e087f97ca515L25
The translation can be done manually or in semi automatic way, uncommenting a function in PR https://github.com/apache/datafusion/pull/13669 locally. This will generate local text files with attribute text which can be copy pasted to structs. However its still needed to remove code based documentation manually, add imports, etc
Please refer to PR #13646 which completed the migration for aggregation functions
### Describe the solution you'd like
_No response_
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "Chen-Yuan-Lai (via GitHub)" <gi...@apache.org>.
Chen-Yuan-Lai commented on issue #13671:
URL: https://github.com/apache/datafusion/issues/13671#issuecomment-2527959863
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "Chen-Yuan-Lai (via GitHub)" <gi...@apache.org>.
Chen-Yuan-Lai commented on issue #13671:
URL: https://github.com/apache/datafusion/issues/13671#issuecomment-2597243936
@comphead I'll complete these ignored functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao closed issue #13671: doc-gen: Migrate builtin scalar functions from code based documentation to attribute based
URL: https://github.com/apache/datafusion/issues/13671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #13671:
URL: https://github.com/apache/datafusion/issues/13671#issuecomment-2563883540
Thanks for all your work on this! I'll do my best to start reviewing these PR's this weekend if no one beats me to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #13671: doc-gen: Migrate builtin scalar functions from code based documentation to attribute based
URL: https://github.com/apache/datafusion/issues/13671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on issue #13671:
URL: https://github.com/apache/datafusion/issues/13671#issuecomment-2564416664
Supposedly it was closed automatically, I think we can close it once all the PRs merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on issue #13671:
URL: https://github.com/apache/datafusion/issues/13671#issuecomment-2596159010
Okay, I think some still left
- GreatestFunc
- ArrowCastFunc
- ArrowTypeOfFunc
- CoalesceFunc
- GetFieldFunc
- LeastFunc
- NamedStructFunc
- NullIfFunc
- NVLFunc
- NVL2Func
- StructFunc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #13671:
URL: https://github.com/apache/datafusion/issues/13671#issuecomment-2564360376
Thank you @Chen-Yuan-Lai and @Omega359 for driving this forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "Chen-Yuan-Lai (via GitHub)" <gi...@apache.org>.
Chen-Yuan-Lai commented on issue #13671:
URL: https://github.com/apache/datafusion/issues/13671#issuecomment-2563845411
Hi @alamb @Omega359 @comphead I've split the changes into several smaller PRs based on function categories. Could you please review these PRs? Thx 🙏
BTW, I put `Cargo.toml` and `Cargo.lock` changes in #13928 , this PR may need to be merged first than other array functions PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead closed issue #13671: doc-gen: Migrate builtin scalar functions from code based documentation to attribute based
URL: https://github.com/apache/datafusion/issues/13671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] doc-gen: Migrate builtin scalar functions from code based documentation to attribute based [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #13671:
URL: https://github.com/apache/datafusion/issues/13671#issuecomment-2598868919
Nice work everyone and thank you @Chen-Yuan-Lai especially 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org