You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/12/20 17:59:58 UTC

[GitHub] milleruntime commented on a change in pull request #842: More cleanup for WAL

milleruntime commented on a change in pull request #842: More cleanup for WAL
URL: https://github.com/apache/accumulo/pull/842#discussion_r243364723
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
 ##########
 @@ -398,10 +401,12 @@ public static DFSLoggerInputStreams readHeaderAndReturnStream(FSDataInputStream
    */
   public synchronized void open(String address) throws IOException {
     String filename = UUID.randomUUID().toString();
-    log.debug("Address is {}", address);
+    if (log.isDebugEnabled())
 
 Review comment:
   I had added as an optimization but forgot the log4j parameterized statements make these checks obsolete.  I will remove.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services