You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by mc...@apache.org on 2008/03/20 11:33:18 UTC
svn commit: r639234 - in /incubator/tuscany/java/sca/modules/binding-ejb/src:
main/java/org/apache/tuscany/sca/binding/ejb/
main/java/org/apache/tuscany/sca/binding/ejb/corba/
main/java/org/apache/tuscany/sca/binding/ejb/impl/
main/java/org/apache/tusc...
Author: mcombellack
Date: Thu Mar 20 03:33:16 2008
New Revision: 639234
URL: http://svn.apache.org/viewvc?rev=639234&view=rev
Log:
Minor JavaDoc updates and spelling corrections
Modified:
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/EJBBinding.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/ClassLoadingUtil.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/DynamicStubClassLoader.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/Java2IDLUtil.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/impl/EJBBindingImpl.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/provider/EJBBindingProviderFactory.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBHandler.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBLocator.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBObjectFactory.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/InterfaceInfo.java
incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/NamingEndpoint.java
incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/account/Customer.java
incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/org/apache/tuscany/sca/binding/ejb/tests/EJBReferenceTestCase.java
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/EJBBinding.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/EJBBinding.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/EJBBinding.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/EJBBinding.java Thu Mar 20 03:33:16 2008
@@ -28,7 +28,7 @@
* An implementation of EJBBinding.
*/
public interface EJBBinding extends Binding, Base {
- // Contants used when describing the EJB binding
+ // Constants used when describing the EJB binding
// model and for setting up defaults
String BINDING_EJB = "binding.ejb";
QName BINDING_JMS_QNAME = new QName(Constants.SCA10_NS, BINDING_EJB);
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/ClassLoadingUtil.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/ClassLoadingUtil.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/ClassLoadingUtil.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/ClassLoadingUtil.java Thu Mar 20 03:33:16 2008
@@ -259,7 +259,7 @@
private static Class getArrayClass(Class type, int dimension) {
// Array.newInstance() requires an array of the requested number of dimensions
// that gives the size for each dimension. We just request 0 in each of the
- // dimentions, which is not unlike a black hole sigularity.
+ // dimensions, which is not unlike a black hole singularity.
int dimensions[] = new int[dimension];
// create an instance and return the associated class object.
return Array.newInstance(type, dimensions).getClass();
@@ -313,7 +313,7 @@
* @return the equal or smaller list of interfaces
*/
public static Class[] reduceInterfaces(Class[] source) {
- // use a copy of the sorce array
+ // use a copy of the source array
source = (Class[]) source.clone();
for (int leftIndex = 0; leftIndex < source.length-1; leftIndex++) {
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/DynamicStubClassLoader.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/DynamicStubClassLoader.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/DynamicStubClassLoader.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/DynamicStubClassLoader.java Thu Mar 20 03:33:16 2008
@@ -48,7 +48,7 @@
} catch (ClassNotFoundException e) {
}
- // if this is not a class from the org.omb.stub name space don't attempt to generate
+ // if this is not a class from the org.omg.stub name space don't attempt to generate
if (!name.startsWith(PACKAGE_PREFIX)) {
throw new ClassNotFoundException("Could not load class: " + name);
}
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/Java2IDLUtil.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/Java2IDLUtil.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/Java2IDLUtil.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/corba/Java2IDLUtil.java Thu Mar 20 03:33:16 2008
@@ -60,7 +60,7 @@
/**
* Various utility functions.
* <p/>
- * Note: #getORB() and #getCodec() rely on UtilInitializer to initialze the ORB and codec.
+ * Note: #getORB() and #getCodec() rely on UtilInitializer to initialize the ORB and codec.
*
* @version $Rev$ $Date$
* @see UtilInitializer
@@ -101,7 +101,7 @@
private static final Pattern SCOPED_NAME_EXTRACTION_PATTERN = Pattern.compile("(\\\\\\\\)|(\\\\@)|(@)|(\\z)");
/**
- * See csiv2 spec 16.2.5 par. 63-64. We extract the username if any and un-escape any
+ * See csiv2 Specification 16.2.5 par. 63-64. We extract the username if any and un-escape any
* escaped \ and @ characters.
*
* @param scopedNameBytes
@@ -192,15 +192,15 @@
} else if (type == Short.TYPE) {
out.write_short(((Short) object).shortValue());
} else {
- // object types must bbe written in the context of the corba application server
- // which properly write replaces our objects for corba
+ // object types must be written in the context of the CORBA application server
+ // which properly write replaces our objects for CORBA
// ApplicationServer oldApplicationServer = ServerFederation.getApplicationServer();
try {
// ServerFederation.setApplicationServer(corbaApplicationServer);
// todo check if
// copy the result to force replacement
- // corba does not call writeReplace on remote proxies
+ // CORBA does not call writeReplace on remote proxies
//
// HOWEVER, if this is an array, then we don't want to do the replacement
// because we can end up with a replacement element that's not compatible with the
@@ -460,7 +460,7 @@
continue;
}
- // setter property must match gettter return value
+ // setter property must match getter return value
if (!method.getParameterTypes()[0].equals(getter.getReturnType())) {
continue;
}
@@ -577,9 +577,9 @@
}
/**
- * Return the a string containing an underscore '_' index of each uppercase character in the iiop name.
+ * Return the a string containing an underscore '_' index of each uppercase character in the IIOP name.
*
- * This is used for distinction of names that only differ by case, since corba does not support case sensitive names.
+ * This is used for distinction of names that only differ by case, since CORBA does not support case sensitive names.
*/
private static String upperCaseIndexString(String iiopName) {
StringBuffer stringBuffer = new StringBuffer();
@@ -593,9 +593,9 @@
}
/**
- * Replaces any occurnace of the specified "oldChar" with the nes string.
+ * Replaces any occurances of the specified "oldChar" with the new string.
*
- * This is used to replace occurances if '$' in corba names since '$' is a special character
+ * This is used to replace occurances if '$' in CORBA names since '$' is a special character
*/
private static String replace(String source, char oldChar, String newString) {
StringBuffer stringBuffer = new StringBuffer(source.length());
@@ -675,7 +675,7 @@
}
/**
- * Returns a string contianing an encoded class name.
+ * Returns a string containing an encoded class name.
*/
private static String buildClassName(Class type) {
if (type.isArray()) {
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/impl/EJBBindingImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/impl/EJBBindingImpl.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/impl/EJBBindingImpl.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/impl/EJBBindingImpl.java Thu Mar 20 03:33:16 2008
@@ -26,7 +26,7 @@
public class EJBBindingImpl implements EJBBinding {
/**
- * corba location For exmaple,
+ * CORBA location For example,
* "corbaname:iiop:localhost:2809/NameServiceServerRoot#ejb/MyEJBHome"
*/
private String uri;
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/provider/EJBBindingProviderFactory.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/provider/EJBBindingProviderFactory.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/provider/EJBBindingProviderFactory.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/provider/EJBBindingProviderFactory.java Thu Mar 20 03:33:16 2008
@@ -19,7 +19,6 @@
package org.apache.tuscany.sca.binding.ejb.provider;
import org.apache.tuscany.sca.binding.ejb.EJBBinding;
-import org.apache.tuscany.sca.binding.ejb.EJBBindingException;
import org.apache.tuscany.sca.core.ExtensionPointRegistry;
import org.apache.tuscany.sca.provider.BindingProviderFactory;
import org.apache.tuscany.sca.provider.ReferenceBindingProvider;
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBHandler.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBHandler.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBHandler.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBHandler.java Thu Mar 20 03:33:16 2008
@@ -109,7 +109,7 @@
} else {
/*
* A generated ejb stub or it must be an EJB in the same ear as
- * the client or an AppServer with a single classloader, so
+ * the client or an AppServer with a single ClassLoader, so
* reflection can be used directly on the JNDI
*/
JavaReflectionAdapter reflectionAdapter =
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBLocator.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBLocator.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBLocator.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBLocator.java Thu Mar 20 03:33:16 2008
@@ -53,7 +53,7 @@
public static final String DEFAULT_HOST = "127.0.0.1"; // Default host name
// or IP address for
- // Websphere
+ // WebSphere
public static final int DEFAULT_NAMING_PORT = 2809; // Default port
public static final String NAMING_SERVICE = "NameService"; // The name of
// the naming
@@ -115,7 +115,7 @@
if (url != null && (url.startsWith("corbaname:iiop:") || url.startsWith("corbaloc:iiop:"))) {
/**
* corbaname:iiop:<hostName>:<port>/<root>#name corbaloc:iiop:<hostname>:<port>/<root>
- * For exmaple,
+ * For example,
* "corbaname:iiop:localhost:2809/NameServiceServerRoot#ejb/MyEJBHome";
* or "corbaloc:iiop:myhost:2809/NameServiceServerRoot"
*/
@@ -209,7 +209,7 @@
int index = source.indexOf(match, 0);
if (index >= 0) {
- // We have at least one match, so gotta do the
+ // We have at least one match, so got to do the
// work...
StringBuffer result = new StringBuffer(source.length() + 16);
@@ -237,10 +237,10 @@
}
/**
- * Resovled the JNDI name from the initial CosNaming context
+ * Resolved the JNDI name from the initial CosNaming context
*
* @param jndiName
- * @return resovled CORBA ojbect
+ * @return resolved CORBA object
* @throws NamingException
*/
private static org.omg.CORBA.Object resovleString(NamingContextExt initCtx, String jndiName) throws NamingException {
@@ -387,7 +387,7 @@
* @return Escaped stringified name for CosNaming
*/
private static String stringify(String jndiName) {
- // Esacpe . into \. since it's an INS naming delimeter
+ // Escape . into \. since it's an INS naming delimiter
return replace(encode2396(jndiName), ".", "\\.");
}
@@ -398,7 +398,7 @@
* @return corbaname treating "." as a literal
*/
private static String toCorbaname(String jndiName) {
- // Esacpe . into %5C%2E (\.) since it's an INS naming delimeter
+ // Escape . into %5C%2E (\.) since it's an INS naming delimiter
// For example, sca.sample.StockQuote --->
// sca%5C%2Esample%5C%2EStockQuote/StockQuote
return replace(encode2396(jndiName), ".", "%5C%2E");
@@ -409,14 +409,14 @@
return locator;
}
/*
- * For managed env, jndi is assumed to be configured by default For
- * unmanaged environment, jndi could have configured through
+ * For managed env, JNDI is assumed to be configured by default For
+ * unmanaged environment, JNDI could have configured through
* jndi.properties file
*/
if (isJndiConfigured()) {
locator = new JndiLocator();
- } else { // this is definitely JSE env without jndi configured. Use
- // Corba.
+ } else { // this is definitely JSE env without JNDI configured. Use
+ // CORBA.
locator = new CosNamingLocator();
}
return locator;
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBObjectFactory.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBObjectFactory.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBObjectFactory.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/EJBObjectFactory.java Thu Mar 20 03:33:16 2008
@@ -50,7 +50,7 @@
* <p>
* The returned EJB stub may be either the pregenerated EJB stub or a
* dynamic stub. This allows a client to invoke an EJB without requiring any
- * of the pregenerated EJB stub classes be avaiable in the classpath.
+ * of the pregenerated EJB stub classes be available in the classpath.
* <p>
*/
public static Object createStub(NamingEndpoint namingEndpoint, InterfaceInfo ejbInterface) throws NamingException,
@@ -100,7 +100,7 @@
ObjectImpl objectImpl = (ObjectImpl)homeObject;
stub = createEJBObject(objectImpl);
}/**
- * Above checks will be satisfied if Bean is running on servers like Websphere. With this
+ * Above checks will be satisfied if Bean is running on servers like WebSphere. With this
* logic, client (SCA composite with EJB ref binding) doesn't need to include home class or
* client stubs.
*
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/InterfaceInfo.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/InterfaceInfo.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/InterfaceInfo.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/InterfaceInfo.java Thu Mar 20 03:33:16 2008
@@ -30,8 +30,6 @@
import org.apache.tuscany.sca.binding.ejb.corba.Java2IDLUtil;
-// import commonj.sdo.DataObject;
-
/**
* The signature for a java interface
*/
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/NamingEndpoint.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/NamingEndpoint.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/NamingEndpoint.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/main/java/org/apache/tuscany/sca/binding/ejb/util/NamingEndpoint.java Thu Mar 20 03:33:16 2008
@@ -51,7 +51,7 @@
if ((!managed) && name.startsWith("corbaname:iiop:")) {
/**
* if (name.startsWith("corbaname:iiop:")) { corbaname:iiop:<hostName>:<port>/<root>#name
- * For exmaple,
+ * For example,
* "corbaname:iiop:localhost:2809/NameServiceServerRoot#ejb/MyEJBHome";
*/
@@ -60,7 +60,7 @@
throw new IllegalArgumentException("Invalid corbaname: " + name);
}
- this.jndiName = name; // The logical jndi name
+ this.jndiName = name; // The logical JNDI name
this.locator = new EJBLocator(parts[0], managed);
} else {
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/account/Customer.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/account/Customer.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/account/Customer.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/account/Customer.java Thu Mar 20 03:33:16 2008
@@ -28,7 +28,7 @@
* current balance and add the amount to existing balance.
*
* @param String amount to be deposited
- * @return total amount in customer accound after deposit
+ * @return total amount in customer account after deposit
*/
Double depositAmount(java.lang.String accountNo, Double amount);
Modified: incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/org/apache/tuscany/sca/binding/ejb/tests/EJBReferenceTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/org/apache/tuscany/sca/binding/ejb/tests/EJBReferenceTestCase.java?rev=639234&r1=639233&r2=639234&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/org/apache/tuscany/sca/binding/ejb/tests/EJBReferenceTestCase.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ejb/src/test/java/org/apache/tuscany/sca/binding/ejb/tests/EJBReferenceTestCase.java Thu Mar 20 03:33:16 2008
@@ -39,7 +39,7 @@
scaDomain = SCADomain.newInstance("account/account.composite");
- // To capture the network traffice for the MockServer, uncomment the next line
+ // To capture the network traffic for the MockServer, uncomment the next line
// new Thread(new SocketTracer(MOCK_PORT, OPENEJB_PORT)).start();
// Start the mock server to simulate the remote EJB
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org