You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jtjeferreira (via GitHub)" <gi...@apache.org> on 2024/02/24 12:11:08 UTC
[PR] make sure trailers are present in StatusRuntimeException [incubator-pekko-grpc]
jtjeferreira opened a new pull request, #230:
URL: https://github.com/apache/incubator-pekko-grpc/pull/230
When using the pekko-http backend and a `StatusRuntimeException` is returned it lacks metadata.
This PR fixes the case for both headers and trailers
The issue was initially reported in https://github.com/akka/akka-grpc/issues/1814 and I fixed it myself in akka-grpc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] make sure trailers are present in StatusRuntimeException [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #230:
URL: https://github.com/apache/incubator-pekko-grpc/pull/230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] make sure trailers are present in StatusRuntimeException [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #230:
URL: https://github.com/apache/incubator-pekko-grpc/pull/230#issuecomment-1962358045
@jtjeferreira there is a scalafmt issue in PekkoHttpClientUtils.scala - would you be able to fix that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] make sure trailers are present in StatusRuntimeException [incubator-pekko-grpc]
Posted by "jtjeferreira (via GitHub)" <gi...@apache.org>.
jtjeferreira commented on PR #230:
URL: https://github.com/apache/incubator-pekko-grpc/pull/230#issuecomment-1962364677
> @jtjeferreira there is a scalafmt issue in PekkoHttpClientUtils.scala - would you be able to fix that?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org