You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Driesprong, Fokko" <fo...@driesprong.frl> on 2018/11/05 15:27:44 UTC
Re: Python 3 support
Hi Michael,
Thanks for pointing out the Python versions. I'm fine with the suggestion
of supporting 3.4 up to 3.7. I would also consider supporting from 3.5
onwards. Right now I've done some tests against 3.4 and that seems to run
fine. I'm fine with adding the classifiers.
Cheers, Fokko
Op wo 31 okt. 2018 om 15:39 schreef Michael A. Smith <ko...@gmail.com>:
> In comments to https://github.com/apache/avro/pull/347 it was suggested
> that we hold a vote to discuss which versions of Python 3 we consider
> officially supported. I assume we follow the Apache Voting Process for code
> modifications
> <https://www.apache.org/foundation/voting.html#votes-on-code-modification
> >:
>
> Scott Belden used the pypi API to get the following data:
>
> [{"python_version":"3.5","download_count":"30258"},
> {"python_version":"3.6","download_count":"26228"},
> {"python_version":"3.4","download_count":"9140"},
> {"python_version":"3.7","download_count":"2502"},
> {"python_version":null,"download_count":"793"},
> {"python_version":"2.7","download_count":"173"},
> {"python_version":"2.6","download_count":"3"}]
>
> It seems clear that there's still a fair 3.4 user base out there, although
> it's shrinking. So...
>
> - For the package at https://github.com/apache/avro/tree/master/lang/py3
> - For Avro versions < 2.0, at least
> - As long as PYPI is counting python 3.4 downloads at > 1000/month
>
> I move that we consider Python 3.4 and up to the latest release of Python 3
> (currently 3.7) officially supported. If I don't hear any objections by
> Saturday, I'll set the trove classifiers to specify those versions in
> https://github.com/apache/avro/pull/347.
>
> -Michael A. Smith (kojiro/kojiromike)
>
> PS: please kindly let me know if I'm not following some proper procedure.
>
Re: Python 3 support
Posted by "Michael A. Smith" <mi...@smith-li.com>.
Fokko, as far as workflow goes I’m just asking if it’s ok to start merging
PRs that only support 3.5+ after 1.9 “final” goes out.
That would have two consequences:
1. avro-python3-1.9 would work with python3.4 as well as it ever has.
2. Maintenance releases of 1.9 would need to be cut from a 1.9-based branch
instead of master, if we want to continue to support 3.4 at that time.
On Wed, May 8, 2019 at 16:57 Driesprong, Fokko <fo...@driesprong.frl> wrote:
> Michael, after some careful thoughts I think it is too late to remove 3.4
> support in Avro 1.9 since we're passed RC3. I've updated the tickets to
> target this for 1.10.
>
> Cheers, Fokko
>
> Op ma 6 mei 2019 om 10:32 schreef Driesprong, Fokko <fokko@driesprong.frl
> >:
>
> > +1 from my side
> >
> > Thanks Michael for reviving this thread again. Since 3.4 isn't officially
> > supported anymore, I think it is save to drop support for Avro 1.9 as
> well
> > to speed up the deprecation process. In practice it will still work
> against
> > 3.4 until we start using breaking features such as type annotation,
> > f-strings etc.
> >
> > Cheers, Fokko
> >
> > Op za 4 mei 2019 om 20:47 schreef Rajkumar Natarajan <
> raj.cs.psg@gmail.com
> > >
> >
> >> +1
> >>
> >> On Sat, May 4, 2019, 2:37 PM sajuukk <sa...@gmail.com> wrote:
> >>
> >> > +1
> >> >
> >> > W dniu 04.05.2019 o 16:10, Michael A. Smith pisze:
> >> > > Hi, Avro devs, it's time to wake this thread up for a checkpoint.
> >> > >
> >> > > I glanced at pypi stats today and it looks like 3.4 downloads are
> >> usually
> >> > > below 1000. More importantly, Python has already EOL'ed python 3.4.
> >> Do we
> >> > > want to consider python 3.4 support officially dropped as of the 1.9
> >> > > release?
> >> > >
> >> > > That is, even if python 3.4 happens to work in 1.9 when it is
> >> released,
> >> > > only versions 3.5 and up will be officially supported?
> >> > >
> >> > > I don't believe this is terribly controversial, so I'll ask for a
> vote
> >> > now.
> >> > >
> >> > > Please reply +1 if you believe that avro-python3 as of 1.9 considers
> >> 3.4
> >> > > deprecated.
> >> > > Please reply -1 if you believe that in avro-python3 1.9 we should
> >> > continue
> >> > > to make efforts to work in python 3.4.
> >> > > Please reply 0 if you want to make comments, but not vote.
> >> > >
> >> > >
> >>
> https://www.apache.org/foundation/voting.html#votes-on-code-modification
> >> > >
> >> > >
> >> > > On Sat, Nov 10, 2018 at 7:42 PM Piotr Gołąb <sa...@gmail.com>
> >> wrote:
> >> > >
> >> > >> Hi Michael,
> >> > >>
> >> > >> Ok, I think it's good idea to drop the Python 3.4 support after the
> >> last
> >> > >> release of 3.4. We can show deprecation warnings before. By the
> way,
> >> > this
> >> > >> will also be a good opportunity for some refactoring. As for the
> >> Avro on
> >> > >> Python 2.7, my approach would be just leave it as it is now and
> don't
> >> > >> introduce new features.
> >> > >>
> >> > >> Best,
> >> > >> Piotr
> >> > >>
> >> > >>
> >> > >>
> >> > >> --
> >> > >> Sent from:
> >> > >>
> http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html
> >> > >>
> >> >
> >>
> >
>
Re: Python 3 support
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
Michael, after some careful thoughts I think it is too late to remove 3.4
support in Avro 1.9 since we're passed RC3. I've updated the tickets to
target this for 1.10.
Cheers, Fokko
Op ma 6 mei 2019 om 10:32 schreef Driesprong, Fokko <fo...@driesprong.frl>:
> +1 from my side
>
> Thanks Michael for reviving this thread again. Since 3.4 isn't officially
> supported anymore, I think it is save to drop support for Avro 1.9 as well
> to speed up the deprecation process. In practice it will still work against
> 3.4 until we start using breaking features such as type annotation,
> f-strings etc.
>
> Cheers, Fokko
>
> Op za 4 mei 2019 om 20:47 schreef Rajkumar Natarajan <raj.cs.psg@gmail.com
> >
>
>> +1
>>
>> On Sat, May 4, 2019, 2:37 PM sajuukk <sa...@gmail.com> wrote:
>>
>> > +1
>> >
>> > W dniu 04.05.2019 o 16:10, Michael A. Smith pisze:
>> > > Hi, Avro devs, it's time to wake this thread up for a checkpoint.
>> > >
>> > > I glanced at pypi stats today and it looks like 3.4 downloads are
>> usually
>> > > below 1000. More importantly, Python has already EOL'ed python 3.4.
>> Do we
>> > > want to consider python 3.4 support officially dropped as of the 1.9
>> > > release?
>> > >
>> > > That is, even if python 3.4 happens to work in 1.9 when it is
>> released,
>> > > only versions 3.5 and up will be officially supported?
>> > >
>> > > I don't believe this is terribly controversial, so I'll ask for a vote
>> > now.
>> > >
>> > > Please reply +1 if you believe that avro-python3 as of 1.9 considers
>> 3.4
>> > > deprecated.
>> > > Please reply -1 if you believe that in avro-python3 1.9 we should
>> > continue
>> > > to make efforts to work in python 3.4.
>> > > Please reply 0 if you want to make comments, but not vote.
>> > >
>> > >
>> https://www.apache.org/foundation/voting.html#votes-on-code-modification
>> > >
>> > >
>> > > On Sat, Nov 10, 2018 at 7:42 PM Piotr Gołąb <sa...@gmail.com>
>> wrote:
>> > >
>> > >> Hi Michael,
>> > >>
>> > >> Ok, I think it's good idea to drop the Python 3.4 support after the
>> last
>> > >> release of 3.4. We can show deprecation warnings before. By the way,
>> > this
>> > >> will also be a good opportunity for some refactoring. As for the
>> Avro on
>> > >> Python 2.7, my approach would be just leave it as it is now and don't
>> > >> introduce new features.
>> > >>
>> > >> Best,
>> > >> Piotr
>> > >>
>> > >>
>> > >>
>> > >> --
>> > >> Sent from:
>> > >> http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html
>> > >>
>> >
>>
>
Re: Python 3 support
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
+1 from my side
Thanks Michael for reviving this thread again. Since 3.4 isn't officially
supported anymore, I think it is save to drop support for Avro 1.9 as well
to speed up the deprecation process. In practice it will still work against
3.4 until we start using breaking features such as type annotation,
f-strings etc.
Cheers, Fokko
Op za 4 mei 2019 om 20:47 schreef Rajkumar Natarajan <ra...@gmail.com>
> +1
>
> On Sat, May 4, 2019, 2:37 PM sajuukk <sa...@gmail.com> wrote:
>
> > +1
> >
> > W dniu 04.05.2019 o 16:10, Michael A. Smith pisze:
> > > Hi, Avro devs, it's time to wake this thread up for a checkpoint.
> > >
> > > I glanced at pypi stats today and it looks like 3.4 downloads are
> usually
> > > below 1000. More importantly, Python has already EOL'ed python 3.4. Do
> we
> > > want to consider python 3.4 support officially dropped as of the 1.9
> > > release?
> > >
> > > That is, even if python 3.4 happens to work in 1.9 when it is released,
> > > only versions 3.5 and up will be officially supported?
> > >
> > > I don't believe this is terribly controversial, so I'll ask for a vote
> > now.
> > >
> > > Please reply +1 if you believe that avro-python3 as of 1.9 considers
> 3.4
> > > deprecated.
> > > Please reply -1 if you believe that in avro-python3 1.9 we should
> > continue
> > > to make efforts to work in python 3.4.
> > > Please reply 0 if you want to make comments, but not vote.
> > >
> > >
> https://www.apache.org/foundation/voting.html#votes-on-code-modification
> > >
> > >
> > > On Sat, Nov 10, 2018 at 7:42 PM Piotr Gołąb <sa...@gmail.com> wrote:
> > >
> > >> Hi Michael,
> > >>
> > >> Ok, I think it's good idea to drop the Python 3.4 support after the
> last
> > >> release of 3.4. We can show deprecation warnings before. By the way,
> > this
> > >> will also be a good opportunity for some refactoring. As for the Avro
> on
> > >> Python 2.7, my approach would be just leave it as it is now and don't
> > >> introduce new features.
> > >>
> > >> Best,
> > >> Piotr
> > >>
> > >>
> > >>
> > >> --
> > >> Sent from:
> > >> http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html
> > >>
> >
>
Re: Python 3 support
Posted by Rajkumar Natarajan <ra...@gmail.com>.
+1
On Sat, May 4, 2019, 2:37 PM sajuukk <sa...@gmail.com> wrote:
> +1
>
> W dniu 04.05.2019 o 16:10, Michael A. Smith pisze:
> > Hi, Avro devs, it's time to wake this thread up for a checkpoint.
> >
> > I glanced at pypi stats today and it looks like 3.4 downloads are usually
> > below 1000. More importantly, Python has already EOL'ed python 3.4. Do we
> > want to consider python 3.4 support officially dropped as of the 1.9
> > release?
> >
> > That is, even if python 3.4 happens to work in 1.9 when it is released,
> > only versions 3.5 and up will be officially supported?
> >
> > I don't believe this is terribly controversial, so I'll ask for a vote
> now.
> >
> > Please reply +1 if you believe that avro-python3 as of 1.9 considers 3.4
> > deprecated.
> > Please reply -1 if you believe that in avro-python3 1.9 we should
> continue
> > to make efforts to work in python 3.4.
> > Please reply 0 if you want to make comments, but not vote.
> >
> > https://www.apache.org/foundation/voting.html#votes-on-code-modification
> >
> >
> > On Sat, Nov 10, 2018 at 7:42 PM Piotr Gołąb <sa...@gmail.com> wrote:
> >
> >> Hi Michael,
> >>
> >> Ok, I think it's good idea to drop the Python 3.4 support after the last
> >> release of 3.4. We can show deprecation warnings before. By the way,
> this
> >> will also be a good opportunity for some refactoring. As for the Avro on
> >> Python 2.7, my approach would be just leave it as it is now and don't
> >> introduce new features.
> >>
> >> Best,
> >> Piotr
> >>
> >>
> >>
> >> --
> >> Sent from:
> >> http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html
> >>
>
Re: Python 3 support
Posted by sajuukk <sa...@gmail.com>.
+1
W dniu 04.05.2019 o 16:10, Michael A. Smith pisze:
> Hi, Avro devs, it's time to wake this thread up for a checkpoint.
>
> I glanced at pypi stats today and it looks like 3.4 downloads are usually
> below 1000. More importantly, Python has already EOL'ed python 3.4. Do we
> want to consider python 3.4 support officially dropped as of the 1.9
> release?
>
> That is, even if python 3.4 happens to work in 1.9 when it is released,
> only versions 3.5 and up will be officially supported?
>
> I don't believe this is terribly controversial, so I'll ask for a vote now.
>
> Please reply +1 if you believe that avro-python3 as of 1.9 considers 3.4
> deprecated.
> Please reply -1 if you believe that in avro-python3 1.9 we should continue
> to make efforts to work in python 3.4.
> Please reply 0 if you want to make comments, but not vote.
>
> https://www.apache.org/foundation/voting.html#votes-on-code-modification
>
>
> On Sat, Nov 10, 2018 at 7:42 PM Piotr Gołąb <sa...@gmail.com> wrote:
>
>> Hi Michael,
>>
>> Ok, I think it's good idea to drop the Python 3.4 support after the last
>> release of 3.4. We can show deprecation warnings before. By the way, this
>> will also be a good opportunity for some refactoring. As for the Avro on
>> Python 2.7, my approach would be just leave it as it is now and don't
>> introduce new features.
>>
>> Best,
>> Piotr
>>
>>
>>
>> --
>> Sent from:
>> http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html
>>
Re: Python 3 support
Posted by "Michael A. Smith" <mi...@smith-li.com>.
Hi, Avro devs, it's time to wake this thread up for a checkpoint.
I glanced at pypi stats today and it looks like 3.4 downloads are usually
below 1000. More importantly, Python has already EOL'ed python 3.4. Do we
want to consider python 3.4 support officially dropped as of the 1.9
release?
That is, even if python 3.4 happens to work in 1.9 when it is released,
only versions 3.5 and up will be officially supported?
I don't believe this is terribly controversial, so I'll ask for a vote now.
Please reply +1 if you believe that avro-python3 as of 1.9 considers 3.4
deprecated.
Please reply -1 if you believe that in avro-python3 1.9 we should continue
to make efforts to work in python 3.4.
Please reply 0 if you want to make comments, but not vote.
https://www.apache.org/foundation/voting.html#votes-on-code-modification
On Sat, Nov 10, 2018 at 7:42 PM Piotr Gołąb <sa...@gmail.com> wrote:
> Hi Michael,
>
> Ok, I think it's good idea to drop the Python 3.4 support after the last
> release of 3.4. We can show deprecation warnings before. By the way, this
> will also be a good opportunity for some refactoring. As for the Avro on
> Python 2.7, my approach would be just leave it as it is now and don't
> introduce new features.
>
> Best,
> Piotr
>
>
>
> --
> Sent from:
> http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html
>
Re: Python 3 support
Posted by Piotr Gołąb <sa...@gmail.com>.
Hi Michael,
Ok, I think it's good idea to drop the Python 3.4 support after the last
release of 3.4. We can show deprecation warnings before. By the way, this
will also be a good opportunity for some refactoring. As for the Avro on
Python 2.7, my approach would be just leave it as it is now and don't
introduce new features.
Best,
Piotr
--
Sent from: http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html
Re: Python 3 support
Posted by "Michael A. Smith" <mi...@smith-li.com>.
Hi, Piotr,
Thanks for posting this for discussion.
In my work projects we use Python 3.6, 3.7, and (cough) 2.7. So it won’t
hurt me directly if Avro doesn’t support Python 3.4 anymore. However,
avro-py3 is a library, so wide version support is appropriate in my opinion.
Python still supports 3.4. There will be one more supported release next
March if it all goes according to the release schedule in PEP 429.
As you previously pointed out, 13% of pypi downloads in one recent month
indicated 3.4. But I don’t think that’s a small number. I think that’s a
worthwhile-sized minority.
I would love to use fstrings. Even moreso I want to use native type hints,
and then get mypy running on yetus. But I genuinely think supporting 3.4 as
long as Python does is the right thing to do for now.
That said, I think we should also plan to deprecate it soon. We can drop
deprecation warnings in the code now and plan to obsolete it completely in
2019.
That’s my opinion. If Apache/avro has an official version compatibility
support policy, someone please clue us in!
https://www.python.org/dev/peps/pep-0429/#id4
On Thu, Nov 8, 2018 at 14:28 Piotr Gołąb <sa...@gmail.com> wrote:
> Hi Michael and Fokko,
>
> I posted some notes today morning, but it was too late I guess.
>
> Isn't the decision to use Python 3.4 too conservative? 3.4 was released on
> 2014 and I strongly believe that we should be as up-to-date as possible.
> 3.4
> is used by around 13% of users as shown by Scott Belden and indeed this
> will
> shrink. At the same time we cannot use some of the features that seem
> obvious in Python 3 (f string formatting, etc.).
>
> Also I think supporting three last minor versions is a good practice, for
> example pandas is supporting Python 3.5, 3.6 and 3.7. What do you think
> about this?
>
> By the way, big thanks for supporting the Python Avro! I'm really glad that
> you're bringing up this discussion.
>
> Best,
> Piotr (sireliah)
>
>
>
>
>
> --
> Sent from:
> http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html
>
Re: Python 3 support
Posted by Piotr Gołąb <sa...@gmail.com>.
Hi Michael and Fokko,
I posted some notes today morning, but it was too late I guess.
Isn't the decision to use Python 3.4 too conservative? 3.4 was released on
2014 and I strongly believe that we should be as up-to-date as possible. 3.4
is used by around 13% of users as shown by Scott Belden and indeed this will
shrink. At the same time we cannot use some of the features that seem
obvious in Python 3 (f string formatting, etc.).
Also I think supporting three last minor versions is a good practice, for
example pandas is supporting Python 3.5, 3.6 and 3.7. What do you think
about this?
By the way, big thanks for supporting the Python Avro! I'm really glad that
you're bringing up this discussion.
Best,
Piotr (sireliah)
--
Sent from: http://apache-avro.679487.n3.nabble.com/Avro-Developers-f679485.html