You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/06/09 07:52:13 UTC
Review Request 35235: DRILL-3262: Rename DrillDatabaseMetaData ->
DrillDatabaseMetaDataImpl.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35235/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-3262
https://issues.apache.org/jira/browse/DRILL-3262
Repository: drill-git
Description
-------
Renamed org.apache.drill.jdbc.impl.DrillDatabaseMetaData to
org.apache.drill.jdbc.impl.DrillDatabaseMetaDataImpl (re creating
org.apache.drill.jdbc.DrillDatabaseMetaDataImpl for DRILL-3198).
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
Diff: https://reviews.apache.org/r/35235/diff/
Testing
-------
Ran tests; no new failures.
Thanks,
Daniel Barclay
Re: Review Request 35235: DRILL-3262: Rename DrillDatabaseMetaData ->
DrillDatabaseMetaDataImpl.
Posted by Daniel Barclay <db...@maprtech.com>.
> On June 11, 2015, 11:38 p.m., Parth Chandra wrote:
> > There appears to be an empty file in this patch. Can you fix that?
Fixed (re-built and re-uploaded patch files).
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35235/#review87650
-----------------------------------------------------------
On June 12, 2015, 10:50 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35235/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 10:50 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-3262
> https://issues.apache.org/jira/browse/DRILL-3262
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Renamed org.apache.drill.jdbc.impl.DrillDatabaseMetaData to
> org.apache.drill.jdbc.impl.DrillDatabaseMetaDataImpl (re creating
> org.apache.drill.jdbc.DrillDatabaseMetaDataImpl for DRILL-3198).
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35235/diff/
>
>
> Testing
> -------
>
> Ran tests; no new failures.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 35235: DRILL-3262: Rename DrillDatabaseMetaData ->
DrillDatabaseMetaDataImpl.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35235/#review87650
-----------------------------------------------------------
There appears to be an empty file in this patch. Can you fix that?
- Parth Chandra
On June 9, 2015, 5:46 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35235/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 5:46 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-3262
> https://issues.apache.org/jira/browse/DRILL-3262
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Renamed org.apache.drill.jdbc.impl.DrillDatabaseMetaData to
> org.apache.drill.jdbc.impl.DrillDatabaseMetaDataImpl (re creating
> org.apache.drill.jdbc.DrillDatabaseMetaDataImpl for DRILL-3198).
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35235/diff/
>
>
> Testing
> -------
>
> Ran tests; no new failures.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 35235: DRILL-3262: Rename DrillDatabaseMetaData ->
DrillDatabaseMetaDataImpl.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35235/#review88097
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On June 12, 2015, 11:17 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35235/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 11:17 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-3262
> https://issues.apache.org/jira/browse/DRILL-3262
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Renamed org.apache.drill.jdbc.impl.DrillDatabaseMetaData to
> org.apache.drill.jdbc.impl.DrillDatabaseMetaDataImpl (re creating
> org.apache.drill.jdbc.DrillDatabaseMetaDataImpl for DRILL-3198).
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35235/diff/
>
>
> Testing
> -------
>
> Ran tests; no new failures.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 35235: DRILL-3262: Rename DrillDatabaseMetaData ->
DrillDatabaseMetaDataImpl.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35235/
-----------------------------------------------------------
(Updated June 12, 2015, 11:17 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-3262
https://issues.apache.org/jira/browse/DRILL-3262
Repository: drill-git
Description
-------
Renamed org.apache.drill.jdbc.impl.DrillDatabaseMetaData to
org.apache.drill.jdbc.impl.DrillDatabaseMetaDataImpl (re creating
org.apache.drill.jdbc.DrillDatabaseMetaDataImpl for DRILL-3198).
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
Diff: https://reviews.apache.org/r/35235/diff/
Testing
-------
Ran tests; no new failures.
Thanks,
Daniel Barclay
Re: Review Request 35235: DRILL-3262: Rename DrillDatabaseMetaData ->
DrillDatabaseMetaDataImpl.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35235/
-----------------------------------------------------------
(Updated June 12, 2015, 10:50 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Fixed bad patch uploading.
Bugs: DRILL-3262
https://issues.apache.org/jira/browse/DRILL-3262
Repository: drill-git
Description
-------
Renamed org.apache.drill.jdbc.impl.DrillDatabaseMetaData to
org.apache.drill.jdbc.impl.DrillDatabaseMetaDataImpl (re creating
org.apache.drill.jdbc.DrillDatabaseMetaDataImpl for DRILL-3198).
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
Diff: https://reviews.apache.org/r/35235/diff/
Testing
-------
Ran tests; no new failures.
Thanks,
Daniel Barclay
Re: Review Request 35235: DRILL-3262: Rename DrillDatabaseMetaData ->
DrillDatabaseMetaDataImpl.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35235/
-----------------------------------------------------------
(Updated June 9, 2015, 5:46 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-3262
https://issues.apache.org/jira/browse/DRILL-3262
Repository: drill-git
Description
-------
Renamed org.apache.drill.jdbc.impl.DrillDatabaseMetaData to
org.apache.drill.jdbc.impl.DrillDatabaseMetaDataImpl (re creating
org.apache.drill.jdbc.DrillDatabaseMetaDataImpl for DRILL-3198).
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
Diff: https://reviews.apache.org/r/35235/diff/
Testing
-------
Ran tests; no new failures.
Thanks,
Daniel Barclay
Re: Review Request 35235: DRILL-3262: Rename DrillDatabaseMetaData ->
DrillDatabaseMetaDataImpl.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35235/
-----------------------------------------------------------
(Updated June 9, 2015, 6:38 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-3262
https://issues.apache.org/jira/browse/DRILL-3262
Repository: drill-git
Description
-------
Renamed org.apache.drill.jdbc.impl.DrillDatabaseMetaData to
org.apache.drill.jdbc.impl.DrillDatabaseMetaDataImpl (re creating
org.apache.drill.jdbc.DrillDatabaseMetaDataImpl for DRILL-3198).
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaData.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
Diff: https://reviews.apache.org/r/35235/diff/
Testing
-------
Ran tests; no new failures.
Thanks,
Daniel Barclay