[GitHub] [superset] hughhhh commented on a change in pull request #15124: fixing api tests

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #15124:
URL: https://github.com/apache/superset/pull/15124#discussion_r650163253



##########
File path: tests/databases/api_tests.py
##########
@@ -278,37 +278,6 @@ def test_create_database_invalid_configuration_method(self):
         }
         assert rv.status_code == 400
 
-    # add this test back in when config method becomes required for creation.
-    # def test_create_database_no_configuration_method(self):

Review comment:
       don't we want to add this back?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org