You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "celalettin1286 (via GitHub)" <gi...@apache.org> on 2023/09/22 16:09:19 UTC
[GitHub] [superset] celalettin1286 opened a new pull request, #25373: fix(helm chart): set chart appVersion to 3.0.0
celalettin1286 opened a new pull request, #25373:
URL: https://github.com/apache/superset/pull/25373
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
here: https://github.com/apache/superset/blob/0c083bdc1af4e6a3e17155246a3134cb5cb5887d/helm/superset/templates/deployment.yaml#L90 it gets the appVersion if tag null but app image tag is 3.0.0 not 3.0 causes image pull issues if superset deployed with default values
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #25373: fix(helm chart): set chart appVersion to 3.0.0
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #25373:
URL: https://github.com/apache/superset/pull/25373#issuecomment-1733609461
> @michael-s-molina should we update the README on RELEASING?
@dpgaspar We have a scheduled meeting to review the release process and one of the questions is about the officially supported artifacts. If Helm ends up being officially supported, then we need to update the `README`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #25373: fix(helm chart): set chart appVersion to 3.0.0
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #25373:
URL: https://github.com/apache/superset/pull/25373#issuecomment-1735760811
Linting still failing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] celalettin1286 commented on pull request #25373: fix(helm chart): set chart appVersion to 3.0.0
Posted by "celalettin1286 (via GitHub)" <gi...@apache.org>.
celalettin1286 commented on PR #25373:
URL: https://github.com/apache/superset/pull/25373#issuecomment-1740769894
> Linting still failing...
I guess it was not happy about README just updated it also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #25373: fix(helm chart): set chart appVersion to 3.0.0
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #25373:
URL: https://github.com/apache/superset/pull/25373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org