You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2010/09/19 19:54:51 UTC
Re: maincss.css : relative path error
I exhumed this one and think we really need to do that.
Jacques
From: "Ryan Foster" <ry...@hotwaxmedia.com>
> So it sounds like the simplest solution would be to copy the styles
> used by the email templates from maincss.css to ecommain.css and then
> change the path to point to ecommain.css.
>
> One thing I would like to propose for development going forward,
> however, is that we move ecommain.css and related images into its own
> folder in the /themes directory and classify it as a front-end theme
> as well, just the same we have done for the rest of the themes
> (bizznesstime, flatgrey, multiflex, bluelight, etc.). Now that we
> have implemented themes functionality, it doesn't make sense to leave
> ecommain.css in the framework images folder. There should be no
> reason we should have any hard-coded stylesheet values in screen
> definitions or Freemarker templates in the framework, front-end or
> back-office. This should be controlled by the theme parameters.
>
> Ryan Foster
> HotWax Media
> 801.671.0769
> ryan.foster@hotwaxmedia.com
>
>
>
>
> On Sep 14, 2009, at 6:59 AM, Scott Gray wrote:
>
>> They may display better with main.css but if they are ecommerce
>> emails then they should use the ecommerce stylesheet.
>>
>> Regards
>> Scott
>>
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> On 15/09/2009, at 12:47 AM, Eric DE MAULDE wrote:
>>
>>> Thanks Ryan
>>>
>>> I don't have a solution to manage maincss.css according to the theme.
>>>
>>> For example, mails are a better display with maincss.css than
>>> ecommain.css
>>>
>>> Eric
>>>
>>> ----- Original Message ----- From: "Ryan Foster" <ryan.foster@hotwaxmedia.com
>>> >
>>> To: <us...@ofbiz.apache.org>
>>> Sent: Monday, September 14, 2009 5:58 AM
>>> Subject: Re: maincss.css : relative path error
>>>
>>>
>>>> Jacques,
>>>> That is correct. There is only one maincss.css file. It used to
>>>> be located in the images folder when "flatgrey" was the only/
>>>> default theme for the OFBiz back office applications. It was
>>>> moved to the / flatgrey webapp theme when we added the additional
>>>> themes (bizznesstime and bluelight) and made bizznesstime the
>>>> default theme.
>>>> Eric,
>>>> It does appear the files you listed do have an incorrect relative
>>>> path. However, it seems to me that there is another problem
>>>> beyond the relative path issue. The files mentioned below apply
>>>> to the ecommerce component don't they? They should be
>>>> referencing ecommain.css not maincss.css. Also, any back office
>>>> screen view should not have a hard-coded path to maincss.css
>>>> anyway. The stylesheet should be controlled by the themes
>>>> component.
>>>> Ryan Foster
>>>> HotWax Media
>>>> 801.671.0769
>>>> ryan.foster@hotwaxmedia.com
>>>> On Sep 10, 2009, at 2:06 AM, Jacques Le Roux wrote:
>>>>> Hi Eric,
>>>>>
>>>>> I'm not totally sure, but as there are no other maincss.css file
>>>>> I guess so... Maybe there is something else to change, themes
>>>>> gurus ?
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Eric DE MAULDE" <er...@free.fr>
>>>>> Hi
>>>>>
>>>>> maincss.css file is into the webapp "flatgrey"
>>>>> So its relative path is "/flatgrey/maincss.css"
>>>>>
>>>>> But a lot of files include a wrong relative path :
>>>>> ${baseUrl}/images/maincss.css
>>>>>
>>>>> Files are :
>>>>> OrderNoticeEmail.ftl
>>>>> ContactListVerifyEmail.ftl
>>>>> /ecommerce/blog/main.ftl
>>>>> webpos/widget/CommonScreens.xml
>>>>> ...
>>>>>
>>>>>
>>>>> Is there an error ?
>>>>> Have I to create a patch ?
>>>>>
>>>>> Eric
>>>>>
>>>>
>>
>
>
Re: maincss.css : relative path error
Posted by BJ Freeman <bj...@free-man.net>.
with the emails in common, how about making a email.css
Since css stand for Cascading Style sheets I think it time we start to
section off the css's by the component.
Have a basic theme that that installs them and access them.
Oh did I just make a simple task hard.. LOL
well some day.
Jacques Le Roux sent the following on 9/19/2010 10:54 AM:
> I exhumed this one and think we really need to do that.
>
> Jacques
>
> From: "Ryan Foster" <ry...@hotwaxmedia.com>
>> So it sounds like the simplest solution would be to copy the styles
>> used by the email templates from maincss.css to ecommain.css and then
>> change the path to point to ecommain.css.
>>
>> One thing I would like to propose for development going forward,
>> however, is that we move ecommain.css and related images into its own
>> folder in the /themes directory and classify it as a front-end theme
>> as well, just the same we have done for the rest of the themes
>> (bizznesstime, flatgrey, multiflex, bluelight, etc.). Now that we have
>> implemented themes functionality, it doesn't make sense to leave
>> ecommain.css in the framework images folder. There should be no reason
>> we should have any hard-coded stylesheet values in screen definitions
>> or Freemarker templates in the framework, front-end or back-office.
>> This should be controlled by the theme parameters.
>>
>> Ryan Foster
>> HotWax Media
>> 801.671.0769
>> ryan.foster@hotwaxmedia.com
>>
>>
>>
>>
>> On Sep 14, 2009, at 6:59 AM, Scott Gray wrote:
>>
>>> They may display better with main.css but if they are ecommerce
>>> emails then they should use the ecommerce stylesheet.
>>>
>>> Regards
>>> Scott
>>>
>>> HotWax Media
>>> http://www.hotwaxmedia.com
>>>
>>> On 15/09/2009, at 12:47 AM, Eric DE MAULDE wrote:
>>>
>>>> Thanks Ryan
>>>>
>>>> I don't have a solution to manage maincss.css according to the theme.
>>>>
>>>> For example, mails are a better display with maincss.css than
>>>> ecommain.css
>>>>
>>>> Eric
>>>>
>>>> ----- Original Message ----- From: "Ryan Foster"
>>>> <ryan.foster@hotwaxmedia.com >
>>>> To: <us...@ofbiz.apache.org>
>>>> Sent: Monday, September 14, 2009 5:58 AM
>>>> Subject: Re: maincss.css : relative path error
>>>>
>>>>
>>>>> Jacques,
>>>>> That is correct. There is only one maincss.css file. It used to be
>>>>> located in the images folder when "flatgrey" was the only/ default
>>>>> theme for the OFBiz back office applications. It was moved to the /
>>>>> flatgrey webapp theme when we added the additional themes
>>>>> (bizznesstime and bluelight) and made bizznesstime the default theme.
>>>>> Eric,
>>>>> It does appear the files you listed do have an incorrect relative
>>>>> path. However, it seems to me that there is another problem beyond
>>>>> the relative path issue. The files mentioned below apply to the
>>>>> ecommerce component don't they? They should be referencing
>>>>> ecommain.css not maincss.css. Also, any back office screen view
>>>>> should not have a hard-coded path to maincss.css anyway. The
>>>>> stylesheet should be controlled by the themes component.
>>>>> Ryan Foster
>>>>> HotWax Media
>>>>> 801.671.0769
>>>>> ryan.foster@hotwaxmedia.com
>>>>> On Sep 10, 2009, at 2:06 AM, Jacques Le Roux wrote:
>>>>>> Hi Eric,
>>>>>>
>>>>>> I'm not totally sure, but as there are no other maincss.css file I
>>>>>> guess so... Maybe there is something else to change, themes gurus ?
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: "Eric DE MAULDE" <er...@free.fr>
>>>>>> Hi
>>>>>>
>>>>>> maincss.css file is into the webapp "flatgrey"
>>>>>> So its relative path is "/flatgrey/maincss.css"
>>>>>>
>>>>>> But a lot of files include a wrong relative path :
>>>>>> ${baseUrl}/images/maincss.css
>>>>>>
>>>>>> Files are :
>>>>>> OrderNoticeEmail.ftl
>>>>>> ContactListVerifyEmail.ftl
>>>>>> /ecommerce/blog/main.ftl
>>>>>> webpos/widget/CommonScreens.xml
>>>>>> ...
>>>>>>
>>>>>>
>>>>>> Is there an error ?
>>>>>> Have I to create a patch ?
>>>>>>
>>>>>> Eric
>>>>>>
>>>>>
>>>
>>
>>
>
>