You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "shamrickus (via GitHub)" <gi...@apache.org> on 2023/02/28 14:26:05 UTC
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7364: Tpv2 coordinates
shamrickus commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1120108417
##########
CHANGELOG.md:
##########
@@ -30,6 +30,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- [#7296](https://github.com/apache/trafficcontrol/pull/7296) *Traffic Portal* New configuration option in `traffic_portal_properties.json` at `deliveryServices.exposeInactive` controls exposing APIv5 DS Active State options in the TP UI.
- [#7332](https://github.com/apache/trafficcontrol/pull/7332) *Traffic Ops* Creates new role needed for TR to watch TO resources.
- [#7322](https://github.com/apache/trafficcontrol/issues/7322) *t3c Adds support for anycast on http routed edges.
+- [#7364](https://github.com/apache/trafficcontrol/issues/7364) *Traffic Portal* TPv2 Created Coordinates Page Parity.
Review Comment:
We haven't been adding TPv2 (only) stories to the changelog since it's experimental/not released.
##########
experimental/traffic-portal/nightwatch/globals/globals.ts:
##########
@@ -54,8 +56,10 @@ import {
RequestCacheGroup,
ResponseCacheGroup,
ResponsePhysicalLocation,
- RequestPhysicalLocation
+ RequestPhysicalLocation,
+ ResponseCoordinate,
} from "trafficops-types";
+import {RequestCoordinate} from "trafficops-types/dist/coordinate";
Review Comment:
This should be just `.. from "trafficops-types"`
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -629,10 +629,10 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{Version: api.Version{Major: 4, Minor: 0}, Method: http.MethodGet, Path: `logs/newcount/?$`, Handler: logs.GetNewCount, RequiredPrivLevel: auth.PrivLevelReadOnly, RequiredPermissions: []string{"LOG:READ"}, Authenticated: Authenticated, Middlewares: nil, ID: 44058330123},
//Content invalidation jobs
- {Version: api.Version{Major: 4, Minor: 0}, Method: http.MethodGet, Path: `jobs/?$`, Handler: api.ReadHandler(&invalidationjobs.InvalidationJobV4{}), RequiredPrivLevel: auth.PrivLevelReadOnly, RequiredPermissions: nil, Authenticated: Authenticated, Middlewares: nil, ID: 49667820413},
Review Comment:
Rebasing might remove some of these changes but if it doesn't then this needs to be mentioned in the changelog
##########
docs/source/api/v4/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -0,0 +1,55 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-v4-deliveryservices-xmlid-xmlid-sslkeys-renew:
+
+**************************************************
+``deliveryservices/xmlId/{{XMLID}}/sslkeys/renew``
+**************************************************
+
+``POST``
+========
+Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to renew SSL keys for a :term:`Delivery Service`.
+
+:Auth. Required: Yes
+:Roles Required: "admin"
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Response Type: Object
+
+Request Structure
+-----------------
+.. table:: Request Path Parameters
+
+ +-------+------------------------------------------------------+
+ | Name | Description |
+ +=======+======================================================+
+ | XMLID | The 'xml_id' of the desired :term:`Delivery Service` |
+ +-------+------------------------------------------------------+
+
+
+Request Structure
+-----------------
+No parameters available
+
+
+Response Structure
+------------------
+.. code-block:: json
+ :caption: Response Example
Review Comment:
Invalid, I believe it just needs a new line between code-block and caption
##########
docs/source/api/v5/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -0,0 +1,55 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-deliveryservices-xmlid-xmlid-sslkeys-renew:
+
+**************************************************
+``deliveryservices/xmlId/{{XMLID}}/sslkeys/renew``
+**************************************************
+
+``POST``
+========
+Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to renew SSL keys for a :term:`Delivery Service`.
+
+:Auth. Required: Yes
+:Roles Required: "admin"
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Response Type: Object
+
+Request Structure
+-----------------
+.. table:: Request Path Parameters
+
+ +-------+------------------------------------------------------+
+ | Name | Description |
+ +=======+======================================================+
+ | XMLID | The 'xml_id' of the desired :term:`Delivery Service` |
+ +-------+------------------------------------------------------+
+
+
+Request Structure
+-----------------
+No parameters available
+
+
+Response Structure
+------------------
+.. code-block:: json
+ :caption: Response Example
Review Comment:
Invalid
##########
experimental/traffic-portal/nightwatch/globals/globals.ts:
##########
@@ -54,8 +56,10 @@ import {
RequestCacheGroup,
ResponseCacheGroup,
ResponsePhysicalLocation,
- RequestPhysicalLocation
+ RequestPhysicalLocation,
+ ResponseCoordinate,
} from "trafficops-types";
+import {RequestCoordinate} from "trafficops-types/dist/coordinate";
Review Comment:
Also should be spaces between `RequestCoordinate` and the curly brackets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org