[GitHub] [hive] jcamachor commented on a change in pull request #829: Hive JDBC Storage Handler: Support For Writing Data to JDBC Data Source

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #829: Hive JDBC Storage Handler: Support For Writing Data to JDBC Data Source
URL: https://github.com/apache/hive/pull/829#discussion_r339814548
 
 

 ##########
 File path: jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java
 ##########
 @@ -172,6 +177,67 @@ public int getTotalNumberOfRecords(Configuration conf) throws HiveJdbcDatabaseAc
     }
   }
 
+  public RecordWriter getRecordWriter(TaskAttemptContext context)
+          throws IOException {
+    Configuration conf = context.getConfiguration();
 
 Review comment:
   L182-185 can be moved below first if condition.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org