[GitHub] [spark] gengliangwang commented on a change in pull request #30552: [SPARK-33611][UI] Decode Query parameters of the redirect URL for reverse proxy

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #30552:
URL: https://github.com/apache/spark/pull/30552#discussion_r532665674



##########
File path: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala
##########
@@ -401,15 +403,16 @@ private[spark] object JettyUtils extends Logging {
       uri.append(rest)
     }
 
-    val rewrittenURI = URI.create(uri.toString())
+    val rewrittenURI = URI.create(uri.toString()).normalize()
     if (query != null) {
+      val decodedQuery = decodeURL(query, defaultUrlEncoding)

Review comment:
       I also try decoding twice here. It works as well. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org