You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/29 05:43:07 UTC
[GitHub] [spark] LuciferYang commented on a diff in pull request #37700: [SPARK-40251][BUILD][MLLIB] Upgrade dev.ludovic.netlib from 2.2.1 to 3.0.2
LuciferYang commented on code in PR #37700:
URL: https://github.com/apache/spark/pull/37700#discussion_r956913597
##########
mllib/src/main/scala/org/apache/spark/mllib/linalg/LAPACK.scala:
##########
@@ -17,9 +17,9 @@
package org.apache.spark.mllib.linalg
-import dev.ludovic.netlib.{JavaLAPACK => NetlibJavaLAPACK,
- LAPACK => NetlibLAPACK,
- NativeLAPACK => NetlibNativeLAPACK}
+import dev.ludovic.netlib.lapack.{JavaLAPACK => NetlibJavaLAPACK,
Review Comment:
The format of `imports` looks strange, I'm not sure if it's standard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org