You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Amer-Mukhtar (via GitHub)" <gi...@apache.org> on 2026/07/11 20:53:48 UTC
[PR] test(frontend): add unit test coverage for parseLogicalOperatorPortID [texera]
Amer-Mukhtar opened a new pull request, #6345:
URL: https://github.com/apache/texera/pull/6345
Description
What changes were proposed in this PR?
This PR adds unit test coverage for parseLogicalOperatorPortID in frontend/src/app/common/util/logical-operator-port-serde.ts. This is a pure parser function that converts a port-id string into a structured object, and it previously had no tests. A new spec file, logical-operator-port-serde.spec.ts, was added following the style of the existing size-formatter.util.spec.ts. It covers valid inputs, where "input-0" parses to { portNumber: 0, portType: "input" } and "output-12" parses to { portNumber: 12, portType: "output" }, as well as invalid inputs such as "foo-1", "input-", "input-1-2", and the empty string, which all return undefined. This is a test-only change and no production code was modified.
Any related issues, documentation, discussions?
Closes #6257
How was this PR tested?
The new unit tests were run via ng test (vitest runner) and all 6 tests pass. The new file was also checked with prettier and eslint, both of which are clean.
Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): add unit test coverage for parseLogicalOperatorPortID [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6345:
URL: https://github.com/apache/texera/pull/6345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): add unit test coverage for parseLogicalOperatorPortID [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6345:
URL: https://github.com/apache/texera/pull/6345#issuecomment-4948744423
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6345?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 61.15%. Comparing base ([`8ee0cfb`](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1a3ffca`](https://app.codecov.io/gh/apache/texera/commit/1a3ffca8f3f3b1c05b18d9a5777595fa5977b58d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6345 +/- ##
============================================
- Coverage 61.16% 61.15% -0.01%
Complexity 3381 3381
============================================
Files 1140 1140
Lines 44929 44929
Branches 4943 4943
============================================
- Hits 27481 27477 -4
Misses 15930 15930
- Partials 1518 1522 +4
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [8ee0cfb](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [8ee0cfb](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.58% <ø> (ø)` | | Carriedforward from [8ee0cfb](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `9.97% <ø> (ø)` | | Carriedforward from [8ee0cfb](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.30% <ø> (ø)` | | Carriedforward from [8ee0cfb](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.97% <ø> (ø)` | | Carriedforward from [8ee0cfb](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.31% <ø> (-0.01%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | Carriedforward from [8ee0cfb](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.18% <ø> (ø)` | | Carriedforward from [8ee0cfb](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [8ee0cfb](https://app.codecov.io/gh/apache/texera/commit/8ee0cfb61ff8febbf5fe59c6647d86b555f515e2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6345?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): add unit test coverage for parseLogicalOperatorPortID [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6345:
URL: https://github.com/apache/texera/pull/6345#issuecomment-4948724611
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org