[jira] Commented: (JCR-1827) SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container

["Alexander Klimetschek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641734#action_12641734 ] 

Alexander Klimetschek commented on JCR-1827:
--------------------------------------------

Jackrabbit currently is still Java 1.4 compatible, so we cannot use annotations (yet). And this annotation requires a J2EE container. There should be another mechanism for proper shutdown. Apart from that, I wonder why this hasn't been noticed before.

> SessionImpl should have @PreDestroy annotation a method to shut down cleanly from within container
> --------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1827
>                 URL: https://issues.apache.org/jira/browse/JCR-1827
>             Project: Jackrabbit
>          Issue Type: New Feature
>    Affects Versions: core 1.4.6
>            Reporter: Chris Wilkes
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> I'm using Spring and noticed that when I use an ObservationManager to register an eventListener tomcat doesn't shut down properly as the ClientEventPoll thread is still running.  What I've done is annotate a method with the javax @PreDestroy annotation to unregister all listeners and to also call .terminate() on the ClientEventPoll in the ClientObservationManager.
> Ideally this would be done in SessionImpl so that it could go through all the Workspaces and do the same.
> @PreDestroy is a standard java annotation and isn't tied to spring or tomcat.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.