You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/29 01:54:47 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #3452: [IOTDB-1453]Fix result set when the server query time filtered is And

neuyilan commented on a change in pull request #3452:
URL: https://github.com/apache/iotdb/pull/3452#discussion_r660223348



##########
File path: server/src/main/java/org/apache/iotdb/db/utils/TimeValuePairUtils.java
##########
@@ -107,4 +115,228 @@ public static TimeValuePair getEmptyTimeValuePair(TSDataType dataType) {
         throw new UnsupportedOperationException("Unrecognized datatype: " + dataType);
     }
   }
+

Review comment:
       Is those code duplicated with the `org.apache.iotdb.cluster.utils.PartitionUtils.Intervals` ? if yes, why repeat coding in two places？
   Don't repeat yourself.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org